Review main Merged

65683[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Log

Sascha Egerer CR +2 V +2 Easy +3 −3 updated 09/11/20, 07:22

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Sascha Egerer +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1315

  1. Sascha Egerer uploaded patch set 1 09/09/20, 17:17

  2. Sascha Egerer wrote 09/09/20, 17:20

    Topic set to phpstan
  3. Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:20

  4. Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:32

  5. Jörg Bösche voted on patch set 2 V +1 CR +1 09/10/20, 06:15

  6. Sascha Egerer voted on patch set 2 V +1 CR +1 09/10/20, 06:46

  7. TYPO3com voted on patch set 2 V +1 09/10/20, 08:32 Completed build in 11m 29s on Thu, 10 Sep, 08:32 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5463

  8. Daniel Goerz commented on patch set 2 CR -1 09/10/20, 08:33

    patch needs its own forge issue
  9. Daniel Goerz commented on patch set 2 09/10/20, 08:34

    patch needs its own forge issue
  10. Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:42

  11. TYPO3com voted on patch set 3 V +1 09/10/20, 09:09 Completed build in 25m 39s on Thu, 10 Sep, 09:09 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5467

  12. Sascha Egerer voted on patch set 3 V +1 CR +1 09/10/20, 19:53

  13. Jörg Bösche voted on patch set 3 V +1 CR +1 09/11/20, 06:30

  14. Daniel Goerz voted on patch set 3 V +2 CR +2 09/11/20, 07:22

  15. Daniel Goerz merged patch set 4 09/11/20, 07:22