65684[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Crypto
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Daniel Goerz +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1620
-
Sascha Egerer uploaded patch set 1 09/09/20, 17:17
-
Sascha Egerer wrote 09/09/20, 17:20
Topic set to phpstan -
Sascha Egerer updated the commit message in patch set 2 09/09/20, 17:20
-
Oliver Klee voted on patch set 2 CR +1 09/09/20, 18:33
-
Sascha Egerer commented on patch set 2 CR -1 09/10/20, 07:19
BlowfishPasswordHash.php:216if (!strncmp(self::PREFIX, $salt, strlen(self::PREFIX))) { should be replaced by if (!strcmp(self::PREFIX, $salt)) {BlowfishPasswordHash.php:218This can end up in unexpected behavior again. First of all it should be checked if the $ does exist at all in the string. But this is again another topic and not part of this patch.Pbkdf2PasswordHash.php:71If getHashedPasswordInternal returns null we don't need to call hash_equals. $hashedPasswordInternal = $this->getHashedPasswordInternal($plainPW, $saltedHashPW); if ($hashedPasswordInternal === null) { return false; } return $this->isValidSalt($saltedHashPW) && hash_equals($hashedPasswordInternal, $saltedHashPW);Pbkdf2PasswordHash.php:238UnresolvedSame as in BlowfishPassword classPhpassPasswordHash.php:253UnresolvedSame as in BlowfishPassword classPhpassPasswordHash.php:255UnresolvedI'm not that deep in the topic but i wonder why it is "+ 2" here -
Daniel Goerz updated the commit message in patch set 3 09/10/20, 08:47
-
TYPO3com voted on patch set 3 V +1 09/10/20, 09:36 Completed build in 36m 37s on Thu, 10 Sep, 09:36 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5474
-
Oliver Klee commented on patch set 3 CR -1 09/26/20, 16:19
Marking -1 so this does not get merged until the comments are addressed. -
Daniel Goerz commented on patch set 3 09/26/20, 16:25
Thanks! -
Alexander Schnitzler uploaded patch set 4 10/06/20, 10:54
-
Alexander Schnitzler uploaded patch set 5 10/06/20, 10:56
-
TYPO3com voted on patch set 4 V -1 10/06/20, 11:07 Completed build in 12m 54s on Tue, 6 Oct, 11:07 AM Test Summary: 108 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6264
-
TYPO3com voted on patch set 5 V -1 10/06/20, 11:12 Completed build in 15m 27s on Tue, 6 Oct, 11:12 AM Test Summary: 108 of 74270 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6265
-
Alexander Schnitzler uploaded patch set 6 10/06/20, 11:29
-
Alexander Schnitzler commented on patch set 6 10/06/20, 11:32
BlowfishPasswordHash.php:216ReplyThis is not valid since we compare the prefix not the whole string.Pbkdf2PasswordHash.php:71ReplyDaniel and me decided to change this in a dedicated patch since the real fix would be to throw an InvalidArgumentException in getHashedPasswordInternal if the given password is an empty string. -
TYPO3com voted on patch set 6 V +1 10/06/20, 11:46 Completed build in 15m 59s on Tue, 6 Oct, 11:46 AM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6267
-
Daniel Goerz voted on patch set 6 V +1 CR +1 10/06/20, 11:48
-
Alexander Schnitzler voted on patch set 6 V +1 CR +1 10/06/20, 11:56
-
Daniel Goerz voted on patch set 6 V +2 CR +2 10/06/20, 12:20
-
Daniel Goerz merged patch set 7 10/06/20, 12:20