65686[BUGFIX] Disable cross origin check for cropper.js
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
- Oliver Hader +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1113
-
Georg Ringer uploaded patch set 1 09/09/20, 17:52
-
Georg Ringer commented on patch set 1 09/09/20, 17:53
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 09/09/20, 18:50 Completed build in 14m 03s on Wed, 9 Sep, 06:50 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5440
-
Anja Leichsenring commented on patch set 1 09/10/20, 06:47
@Georg what is the relation here that made you add us to reviewers? Which patch / issue was the starting point? -
Andreas Kienast uploaded patch set 2 09/10/20, 06:49
-
TYPO3com voted on patch set 2 V +1 09/10/20, 06:59 Completed build in 10m 32s on Thu, 10 Sep, 06:59 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5461
-
Benni Mack voted on patch set 2 V +1 CR +1 09/10/20, 19:30
-
Oliver Klee voted on patch set 2 CR +1 09/11/20, 09:36
-
Frank Nägler commented on patch set 2 09/11/20, 14:43
I am not sure, but this change looks to be security related. Is it really secure to set this option? Maybe I am to nervous, but please double check the impact regarding possible security issues. -
Oliver Hader commented on patch set 2 CR +1 09/11/20, 15:30
Somehow the credentials (cookie) needs to be sent the the resource server... from a CORS perspective it's fine. I'm not sure if there are other/better ways to do it in cropperjs, see https://github.com/fengyuanchen/cropperjs/blob/master/README.md#checkcrossorigin -
Anja Leichsenring wrote 09/14/20, 06:00
Removed reviewer Anja Leichsenring. -
Daniel Goerz voted on patch set 2 V +2 CR +2 09/20/20, 12:10
-
Daniel Goerz merged patch set 3 09/20/20, 12:10