Review main Merged

65688[BUGFIX] Use named export of BackendExceptionModule in FormEngine

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 12/10/20, 21:16

Commit message

The BackendException class is exported as named (not as default)
export in BackendException.ts, and therefore the module consumer
needs to access the BackendException property of the module.
Fix FormEngine to do so.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1

Issues 1

Files 1

Review log 911

  1. Benjamin Franzke uploaded patch set 1 09/09/20, 19:35

  2. Benjamin Franzke commented on patch set 1 09/09/20, 19:39

    As I don't know of a current way to actually trigger this case, I didn't include a backport to 9.5. @olly, as you authored this in https://review.typo3.org/c/Packages/TYPO3.CMS/+/53075/ – maybe you know whether/how this exception (i.e. no interactionRequest in FormEngine.consume) can be triggered
  3. TYPO3com voted on patch set 1 V +1 09/09/20, 19:48 Completed build in 13m 26s on Wed, 9 Sep, 07:48 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5446

  4. Benjamin Franzke rebased onto patch set 2 12/06/20, 20:20

    This is a rebase on master!
  5. TYPO3com voted on patch set 2 V +1 12/06/20, 20:30 Completed build in 10m 02s on Sun, 6 Dec, 08:30 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7880

  6. Benjamin Franzke commented on patch set 2 12/07/20, 09:36

    For reviewers: You can easily verify that the module TYPO3/CMS/Backend/BackendException exports an object with a key "BackendException" by executing following js in the browser console of your /typo3/ backend: window.require(['TYPO3/CMS/Backend/BackendException'], (BackendExceptionModule) => console.log(BackendExceptionModule)) It logs: {__esModule: true, BackendException: ƒ}
  7. Benjamin Franzke wrote 12/07/20, 19:19

    Topic set to javascript
  8. Benni Mack updated the commit message in patch set 3 12/10/20, 21:11

  9. Benni Mack voted on patch set 3 V +1 CR +1 12/10/20, 21:11

  10. Oliver Hader voted on patch set 3 V +2 CR +2 12/10/20, 21:16

  11. Oliver Hader merged patch set 4 12/10/20, 21:16