Review 10.4 Merged

65690[BUGFIX] Add support for symfony/event-dispatcher-contracts v1

Benjamin Franzke CR +2 V +2 Normal +49 −52 updated 09/09/20, 21:48

Commit message

With the introduction of symfony/event-dispatcher-contracts
in https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e4a1ae8762ee99712
we forced usage of symfony5 in composer-based installations where
installation with symfony4 was possible before. This is because event
contracts v2 is only compatible with symfony v5, but contracts v1 needs to
be supported for symfony4 compatibility.

Note: although non-composer-based installations used symfony5 bundled
already, composer mode could still use symfony v4 if needed.

We now add a new intermediate composer package that is available in two
different versions, and offers a compatible symfony event dispatcher
adapter for the respective interfaces in symfony v4 and symfony v5 in each
of these version. typo3/cms-core allows to install both versions which
means we can provide a compatible adapter for both, symfony v4 and v5.

This change allows composer-based installations to support both
versions (v5/v4) again, so extensions like EXT:solr (which requires
a package called solarium) to work with the dependency constraints
of TYPO3 Core.

Commands used:

  composer require --no-update --working-dir=typo3/sysext/core \
    "symfony/event-dispatcher-contracts:^1.1 || ^2.0" \
    "typo3/symfony-psr-event-dispatcher-adapter:^1.0 || ^2.0"

  composer require --no-update \
    "symfony/event-dispatcher-contracts:^1.1 || ^2.0" \
    "typo3/symfony-psr-event-dispatcher-adapter:^1.0 || ^2.0"

  composer update --lock

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 67

  1. Benjamin Franzke uploaded patch set 1 09/09/20, 20:44

  2. Simon Gilli voted on patch set 1 CR +1 09/09/20, 20:50

  3. TYPO3com voted on patch set 1 V +1 09/09/20, 21:01 Completed build in 16m 48s on Wed, 9 Sep, 09:01 PM Test Summary: 74190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-381

  4. Benjamin Franzke voted on patch set 1 V +1 CR +1 09/09/20, 21:33

  5. Simon Gilli voted on patch set 1 V +1 09/09/20, 21:46

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 09/09/20, 21:48

  7. Benjamin Franzke merged patch set 2 09/09/20, 21:48