Review main Merged

65691[BUGFIX] Use correct variable to access language id of a column

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 09/18/20, 19:25

Commit message

The fluid based page module used a non existing
variable to access the language id of a column. This lead
to passing `NaN` as language id to the DataHandler when
moving a content element in the corresponding column.
Therefore the content element was actually moved to the
default column because of the changed language.

The template is now accessing the correct variable fetched from
the SiteLanguage object which makes moving content on translated
pages possible again.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Daniel Goerz +1
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Oli Bartsch uploaded patch set 1 09/09/20, 21:27

  2. TYPO3com voted on patch set 1 V +1 09/09/20, 21:42 Completed build in 14m 53s on Wed, 9 Sep, 09:42 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5451

  3. Jörg Bösche voted on patch set 1 CR +1 09/10/20, 06:10

  4. Riccardo De Contardi commented on patch set 1 V +1 09/10/20, 19:15

    tested on latest master with the setup described on https://forge.typo3.org/issues/92086#note-6
  5. Daniel Goerz voted on patch set 1 V +1 CR +1 09/18/20, 07:41

  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/18/20, 19:19

  7. Christian Kuhn voted on patch set 1 V +1 CR +1 09/18/20, 19:24

  8. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/18/20, 19:25

  9. Anja Leichsenring merged patch set 2 09/18/20, 19:25