Review main Merged

65692[BUGFIX] Ensure composer update --prefer-lowest installs the lowest possible packages

Simon Gilli CR +2 V +2 Easy +1 −0 updated 09/15/20, 18:39

Commit message

Since the change of platform.php in the composer.json to 7.2.5 according
to Symfony 5.x composer does not install the lowest dependencies for
sure. This patch enforces the change of the platform before running
composer update --prefer-lowest

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Helmut Hummel +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Helmut Hummel +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 910

  1. Simon Gilli uploaded patch set 1 09/09/20, 22:28

  2. Simon Gilli marked it work in progress 09/09/20, 22:28

  3. Simon Gilli commented on patch set 1 09/09/20, 22:29

    This change is ready for review.
  4. Simon Gilli marked it work in progress 09/09/20, 22:29

  5. TYPO3com voted on patch set 1 V +1 09/09/20, 22:41 Completed build in 13m 01s on Wed, 9 Sep, 10:41 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5454

  6. Helmut Hummel voted on patch set 1 V +1 CR +1 09/10/20, 08:20

  7. Simon Gilli commented on patch set 1 09/10/20, 22:51

    This change is ready for review.
  8. Benni Mack commented on patch set 1 V +1 CR +1 09/11/20, 09:44

    Please note that TYPO3 v9 would need other constraints (same as in composer.json config platform.php)
  9. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/15/20, 18:39

  10. Anja Leichsenring merged patch set 2 09/15/20, 18:39