Review main Merged

65693[TASK] Streamline usage of contrib packages in TypeScript

Benjamin Franzke CR +2 V +2 Easy +8 −12 updated 11/11/20, 21:24

Commit message

No need to use a fully qualified namespace for
3rd party modules that are placed in TYPO3/CMS/Core/Contrib.
There are usually aliases configured in the requirejs configuration,
and if they are missing, we add them now.

This change additionally drops an unneded module declaration
for "TYPO3/CMS/Core/Contrib/imagesloaded.pkgd.min" which is
not needed when simply using "imagesloaded" as module name.

Commands used:

  grunt build

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 813

  1. Benjamin Franzke uploaded patch set 1 09/10/20, 05:23

  2. Benjamin Franzke updated the commit message in patch set 2 09/10/20, 05:25

  3. TYPO3com voted on patch set 1 V +1 09/10/20, 05:34 Completed build in 11m 33s on Thu, 10 Sep, 05:34 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5459

  4. TYPO3com voted on patch set 2 V +1 09/10/20, 05:39 Completed build in 13m 29s on Thu, 10 Sep, 05:39 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5460

  5. Benjamin Franzke uploaded patch set 3 10/28/20, 05:27

  6. Benjamin Franzke commented on patch set 3 10/28/20, 05:27

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V -1 10/28/20, 05:39 Completed build in 11m 34s on Wed, 28 Oct, 05:39 AM Test Summary: 3 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6952

  8. TYPO3com commented on patch set 3 10/28/20, 06:08 Completed build in 51m 54s on Wed, 28 Oct, 06:08 AM Test Summary: 3 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6952

  9. Oli Bartsch rebased onto patch set 4 10/28/20, 10:07

  10. TYPO3com voted on patch set 4 V +1 10/28/20, 10:22 Completed build in 14m 12s on Wed, 28 Oct, 10:22 AM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6962

  11. Benni Mack voted on patch set 4 V +1 CR +1 10/28/20, 22:59

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 11/11/20, 21:23

  13. Anja Leichsenring merged patch set 5 11/11/20, 21:24