Review main Merged

65695[FEATURE] Enable secure cookies by default

Benni Mack CR +2 V +2 Normal +54 −37 updated 09/11/20, 08:12

Commit message

The option $TYPO3_CONF_VARS[SYS][cookieSecure] is
removed in favor of always setting a secure cookie
on HTTPS requests.

This leads to errors when a page would be available
in HTTP and HTTPS which is normally not the case
when using a full site base in Site Handling anymore,
and making TYPO3 more secure out-of-the-box.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 912

  1. Benni Mack uploaded patch set 1 09/10/20, 10:36

  2. TYPO3com voted on patch set 1 V +1 09/10/20, 10:50 Completed build in 14m 19s on Thu, 10 Sep, 10:50 AM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5489

  3. Benni Mack uploaded patch set 2 09/10/20, 18:51

  4. TYPO3com voted on patch set 2 V +1 09/10/20, 19:10 Completed build in 18m 44s on Thu, 10 Sep, 07:10 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5514

  5. Benni Mack uploaded patch set 3 09/10/20, 19:51

  6. TYPO3com voted on patch set 3 V +1 09/10/20, 20:04 Completed build in 13m 09s on Thu, 10 Sep, 08:04 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5519

  7. Frank Nägler voted on patch set 3 CR +1 09/10/20, 20:13

  8. Frank Nägler voted on patch set 3 V +1 09/10/20, 20:27

  9. Jörg Bösche voted on patch set 3 CR +1 09/11/20, 06:26

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 09/11/20, 06:41

  11. Benni Mack voted on patch set 3 V +2 CR +2 09/11/20, 08:12

  12. Benni Mack merged patch set 4 09/11/20, 08:12