Review main Merged

65699[FEATURE] Add FluidEmail option to EXT:form EmailFinisher

Oli Bartsch CR +2 V +2 Hard +351 −114 updated 09/26/20, 11:00

Commit message

EXT:form, the last system extension not using FluidEmail
was extended for the corresponing integration. To allow
extension authors to smoothly test and upgrade, the old
StandaloneView functionality remains for now.

As there is no change to the present behaviour the switch
can be done without further actions required - if using the
default templates currently.

To migrate custom templates to FluidEmail, the template files
must be changed from the {@format}.html syntax to appropriate
names with the correct format extension like `.html` and `.txt`.
Furthermore the `templateName` option must be set with the new name.

Two fields are introduced to configure FluidEmail in the finishers:

- `useFluidEmail`: Enables sending the mails via FluidEmail
- `title`: Used for the title section of the default template

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 3044

Show 1219 earlier messages
  1. Oli Bartsch uploaded patch set 1 09/10/20, 17:55

  2. Oli Bartsch marked it work in progress 09/10/20, 18:07

  3. TYPO3com voted on patch set 1 V +1 09/10/20, 18:27 Completed build in 13m 19s on Thu, 10 Sep, 06:27 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5509

  4. Mathias Brodala commented on patch set 1 09/11/20, 06:53

    FormEditorController.php:738

    This must be done in a separate change as only change.
  5. Oli Bartsch uploaded patch set 2 09/11/20, 13:31

  6. TYPO3com voted on patch set 2 V -1 09/11/20, 13:42 Completed build in 10m 48s on Fri, 11 Sep, 01:42 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5546

  7. Oli Bartsch uploaded patch set 3 09/11/20, 13:46

  8. Oli Bartsch uploaded patch set 4 09/11/20, 13:50

  9. TYPO3com voted on patch set 3 V -1 09/11/20, 13:57 Completed build in 10m 50s on Fri, 11 Sep, 01:57 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5547

  10. TYPO3com voted on patch set 4 V -1 09/11/20, 14:03 Completed build in 12m 23s on Fri, 11 Sep, 02:03 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5548

  11. Mathias Brodala commented on patch set 4 09/11/20, 14:07

    FormEditorController.php:738 Reply

    Done
  12. Oli Bartsch uploaded patch set 5 09/11/20, 14:28

  13. TYPO3com voted on patch set 5 V +1 09/11/20, 14:39 Completed build in 11m 22s on Fri, 11 Sep, 02:39 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5549

  14. Oli Bartsch uploaded patch set 6 09/14/20, 08:12

  15. TYPO3com voted on patch set 6 V +1 09/14/20, 08:23 Completed build in 10m 52s on Mon, 14 Sep, 08:23 AM Test Summary: 73207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5591

  16. Oli Bartsch commented on patch set 6 09/14/20, 08:39

    This patch is ready to review.
  17. Oli Bartsch uploaded patch set 7 09/22/20, 08:00

  18. TYPO3com voted on patch set 7 V +1 09/22/20, 08:12 Completed build in 11m 13s on Tue, 22 Sep, 08:12 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5804

  19. Georg Ringer commented on patch set 7 CR -1 09/22/20, 15:19

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:16

    I propose adding the names of those finishers

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:18

    remote whitespace

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:20

    form

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:21

    would suggest something like "in the flexform configuration of the form plugin

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:47

    should we skip the last "ContactForm" so that the final template would be then "EXT:sitepackage/Resources/Private/Templates/Email/ContactForm.html/txt"?

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:64

    I am used to uppercase for those ext, used on other places in rst as well
  1. Oli Bartsch uploaded patch set 8 09/22/20, 15:44

  2. Oli Bartsch commented on patch set 8 09/22/20, 15:47

    Also added 10.4 as decided in slack. This however will be a manual backport because we can't remove the deprecations there.

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:16 Reply

    Done

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:18 Reply

    Done

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:20 Reply

    Done

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:21 Reply

    Done

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:47 Reply

    Done

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:64 Reply

    Done
  3. TYPO3com voted on patch set 8 V +1 09/22/20, 15:55 Completed build in 11m 04s on Tue, 22 Sep, 03:55 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5822

  4. Georg Ringer voted on patch set 8 V +1 CR +1 09/22/20, 16:23

  5. Guido Schmechel commented on patch set 8 09/23/20, 15:56

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:14

    EXT:form Sorry :-)
  6. Oli Bartsch commented on patch set 9 09/23/20, 15:59

    Published edit on patch set 8.
  7. Oli Bartsch commented on patch set 9 09/23/20, 16:00

    Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:14 Reply

    Done
  8. TYPO3com voted on patch set 9 V +1 09/23/20, 16:13 Completed build in 13m 30s on Wed, 23 Sep, 04:13 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5880

  9. Guido Schmechel voted on patch set 9 CR +1 09/23/20, 16:14

  10. Oli Bartsch uploaded patch set 10 09/23/20, 17:02

  11. TYPO3com voted on patch set 10 V -1 09/23/20, 17:38 Completed build in 18m 37s on Wed, 23 Sep, 05:38 PM Test Summary: 1 of 74185 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5896

  12. TYPO3com voted on patch set 10 V +1 09/23/20, 18:06 Completed build in 1h 05m 07s on Wed, 23 Sep, 06:06 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5896

  13. Guido Schmechel voted on patch set 10 CR +1 09/24/20, 11:06

  14. Andreas Kienast commented on patch set 10 CR -1 09/26/20, 10:06

    on it

    EmailFinisher.php:121 Unresolved

    empty() already includes isset(), isset is superfluous here

    EmailFinisher.php:256 Unresolved

    `is_array($this->options['templateRootPaths'] ?? null)` makes the previous isset() check obsolete

    EmailFinisher.php:301 Unresolved

    I'd do an is_array() check here
  15. Andreas Kienast uploaded patch set 11 09/26/20, 10:19

  16. Andreas Kienast uploaded patch set 12 09/26/20, 10:20

  17. Andreas Kienast voted on patch set 12 V +1 CR +1 09/26/20, 10:22

  18. TYPO3com voted on patch set 11 V +1 09/26/20, 10:32 Completed build in 12m 24s on Sat, 26 Sep, 10:32 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5979

  19. TYPO3com voted on patch set 12 V +1 09/26/20, 10:36 Completed build in 14m 23s on Sat, 26 Sep, 10:36 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5980

  20. Andreas Kienast uploaded patch set 13 09/26/20, 10:47

  21. Andreas Kienast voted on patch set 13 V +1 CR +1 09/26/20, 10:47

  22. Oli Bartsch commented on patch set 13 V +1 CR +1 09/26/20, 10:49

    Thanks for the adjustments!
  23. TYPO3com voted on patch set 13 V +1 09/26/20, 10:59 Completed build in 11m 24s on Sat, 26 Sep, 10:59 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5981

  24. Georg Ringer voted on patch set 13 V +2 CR +2 09/26/20, 11:00

  25. Georg Ringer merged patch set 14 09/26/20, 11:00