65699[FEATURE] Add FluidEmail option to EXT:form EmailFinisher
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Mail/FluidEmail.php+10 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-90728-AddFluidEmailOptionToEXTformEmailFinisher.rstnew+67 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php3+124 −114
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml+6 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml+6 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+30 −0
- typo3/sysext/form/Configuration/Yaml/Legacy/mixins.yaml+15 −0
- typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Yaml/NewForms/SimpleContactForm.yaml+2 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.htmlnew+45 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.txtnew+16 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+30 −0
Review log 3044
Show 1219 earlier messages
-
Oli Bartsch uploaded patch set 1 09/10/20, 17:55
-
Oli Bartsch marked it work in progress 09/10/20, 18:07
-
TYPO3com voted on patch set 1 V +1 09/10/20, 18:27 Completed build in 13m 19s on Thu, 10 Sep, 06:27 PM Test Summary: 73173 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5509
-
Mathias Brodala commented on patch set 1 09/11/20, 06:53
-
Oli Bartsch uploaded patch set 2 09/11/20, 13:31
-
TYPO3com voted on patch set 2 V -1 09/11/20, 13:42 Completed build in 10m 48s on Fri, 11 Sep, 01:42 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5546
-
Oli Bartsch uploaded patch set 3 09/11/20, 13:46
-
Oli Bartsch uploaded patch set 4 09/11/20, 13:50
-
TYPO3com voted on patch set 3 V -1 09/11/20, 13:57 Completed build in 10m 50s on Fri, 11 Sep, 01:57 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5547
-
TYPO3com voted on patch set 4 V -1 09/11/20, 14:03 Completed build in 12m 23s on Fri, 11 Sep, 02:03 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5548
-
Mathias Brodala commented on patch set 4 09/11/20, 14:07
FormEditorController.php:738ReplyDone -
Oli Bartsch uploaded patch set 5 09/11/20, 14:28
-
TYPO3com voted on patch set 5 V +1 09/11/20, 14:39 Completed build in 11m 22s on Fri, 11 Sep, 02:39 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5549
-
Oli Bartsch uploaded patch set 6 09/14/20, 08:12
-
TYPO3com voted on patch set 6 V +1 09/14/20, 08:23 Completed build in 10m 52s on Mon, 14 Sep, 08:23 AM Test Summary: 73207 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5591
-
Oli Bartsch commented on patch set 6 09/14/20, 08:39
This patch is ready to review. -
Oli Bartsch uploaded patch set 7 09/22/20, 08:00
-
TYPO3com voted on patch set 7 V +1 09/22/20, 08:12 Completed build in 11m 13s on Tue, 22 Sep, 08:12 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5804
-
Georg Ringer commented on patch set 7 CR -1 09/22/20, 15:19
Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:16I propose adding the names of those finishersFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:18remote whitespaceFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:20formFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:21would suggest something like "in the flexform configuration of the form pluginFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:47should we skip the last "ContactForm" so that the final template would be then "EXT:sitepackage/Resources/Private/Templates/Email/ContactForm.html/txt"?Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:64I am used to uppercase for those ext, used on other places in rst as well
-
Oli Bartsch uploaded patch set 8 09/22/20, 15:44
-
Oli Bartsch commented on patch set 8 09/22/20, 15:47
Also added 10.4 as decided in slack. This however will be a manual backport because we can't remove the deprecations there.Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:16ReplyDoneFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:18ReplyDoneFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:20ReplyDoneFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:21ReplyDoneFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:47ReplyDoneFeature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:64ReplyDone -
TYPO3com voted on patch set 8 V +1 09/22/20, 15:55 Completed build in 11m 04s on Tue, 22 Sep, 03:55 PM Test Summary: 73676 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5822
-
Georg Ringer voted on patch set 8 V +1 CR +1 09/22/20, 16:23
-
Guido Schmechel commented on patch set 8 09/23/20, 15:56
Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:14EXT:form Sorry :-) -
Oli Bartsch commented on patch set 9 09/23/20, 15:59
Published edit on patch set 8. -
Oli Bartsch commented on patch set 9 09/23/20, 16:00
Feature-90728-AddFluidEmailOptionToExtformEmailFinisher.rst:14ReplyDone -
TYPO3com voted on patch set 9 V +1 09/23/20, 16:13 Completed build in 13m 30s on Wed, 23 Sep, 04:13 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5880
-
Guido Schmechel voted on patch set 9 CR +1 09/23/20, 16:14
-
Oli Bartsch uploaded patch set 10 09/23/20, 17:02
-
TYPO3com voted on patch set 10 V -1 09/23/20, 17:38 Completed build in 18m 37s on Wed, 23 Sep, 05:38 PM Test Summary: 1 of 74185 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5896
-
TYPO3com voted on patch set 10 V +1 09/23/20, 18:06 Completed build in 1h 05m 07s on Wed, 23 Sep, 06:06 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5896
-
Guido Schmechel voted on patch set 10 CR +1 09/24/20, 11:06
-
Andreas Kienast commented on patch set 10 CR -1 09/26/20, 10:06
on itEmailFinisher.php:121Unresolvedempty() already includes isset(), isset is superfluous hereEmailFinisher.php:256Unresolved`is_array($this->options['templateRootPaths'] ?? null)` makes the previous isset() check obsoleteEmailFinisher.php:301UnresolvedI'd do an is_array() check here -
Andreas Kienast uploaded patch set 11 09/26/20, 10:19
-
Andreas Kienast uploaded patch set 12 09/26/20, 10:20
-
Andreas Kienast voted on patch set 12 V +1 CR +1 09/26/20, 10:22
-
TYPO3com voted on patch set 11 V +1 09/26/20, 10:32 Completed build in 12m 24s on Sat, 26 Sep, 10:32 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5979
-
TYPO3com voted on patch set 12 V +1 09/26/20, 10:36 Completed build in 14m 23s on Sat, 26 Sep, 10:36 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5980
-
Andreas Kienast uploaded patch set 13 09/26/20, 10:47
-
Andreas Kienast voted on patch set 13 V +1 CR +1 09/26/20, 10:47
-
Oli Bartsch commented on patch set 13 V +1 CR +1 09/26/20, 10:49
Thanks for the adjustments! -
TYPO3com voted on patch set 13 V +1 09/26/20, 10:59 Completed build in 11m 24s on Sat, 26 Sep, 10:59 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5981
-
Georg Ringer voted on patch set 13 V +2 CR +2 09/26/20, 11:00
-
Georg Ringer merged patch set 14 09/26/20, 11:00
FormEditorController.php:738