Review main Merged

65701[BUGFIX] Use dedicated property to hide newRecordLink button

Oli Bartsch CR +2 V +2 Easy +28 −1 updated 09/22/20, 16:06

Commit message

Since #71918 the property ['appearance']['enabledControls']['new']
is misused to hide the newRecordLink button of TCA=inline.

This is incorrect because according to documentation enabledControls
only manages the controls, shown in the header of each inline record.
This makes sense for use-cases where e.g. an inline column has
maxitems=1 set. Therefore the control to create a new inline record
afterwards is not needed. The newRecordLink is however definitely
needed to create at least this one inline record.

Furthermore ['enabledControls']['new'] is the only enabledControls
property used in InlineControlContainer, which also indicates its
misuse there.

This check is therefore now replaced by a new dedicated property
`showNewRecordLink`, so it is still possible for extension authors to
hide the newRecordLink independent of the new button in the inline
records controls.

For backwards compatibility the newRecordLink is only hidden if the
`showNewRecordLink` is explicit set to FALSE. If not set the
newRecordLink is shown.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 57

  1. Oli Bartsch uploaded patch set 1 09/11/20, 11:09

  2. TYPO3com voted on patch set 1 V +1 09/11/20, 11:23 Completed build in 14m 14s on Fri, 11 Sep, 11:23 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5537

  3. Oli Bartsch uploaded patch set 2 09/14/20, 11:25

  4. TYPO3com voted on patch set 2 V +1 09/14/20, 11:36 Completed build in 11m 34s on Mon, 14 Sep, 11:36 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5600

  5. Benni Mack voted on patch set 2 V +1 CR +1 09/21/20, 07:52

  6. Georg Ringer voted on patch set 2 V +2 CR +2 09/22/20, 16:06

  7. Georg Ringer merged patch set 3 09/22/20, 16:06