Review main Merged

65702[TASK] Remove unused workspace-related methods

Benni Mack CR +2 V +2 Normal +0 −51 updated 09/11/20, 17:37

Commit message

Due to the removal of branch-based versioning in TYPO3 v8,
there are two methods that can be removed now (as they
have been marked as internal in TYPO3 v10).

* BackendUserAuthentication->workspaceAllowLiveRecordsInPID
* BackendUserAuthentication->workspaceCreateNewRecord

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Benni Mack uploaded patch set 1 09/11/20, 12:11

  2. TYPO3com voted on patch set 1 V +1 09/11/20, 12:23 Completed build in 11m 49s on Fri, 11 Sep, 12:23 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5540

  3. Björn Jacob updated the commit message in patch set 2 09/11/20, 12:40

  4. Björn Jacob commented on patch set 2 CR +1 09/11/20, 12:40

    Just removed a typo in the commit message.
  5. Oli Bartsch uploaded patch set 3 09/11/20, 12:46

  6. Oli Bartsch commented on patch set 3 V +1 CR +1 09/11/20, 12:47

    Just removed a left over comment regarding on of these methods.
  7. Oliver Klee voted on patch set 3 CR +1 09/11/20, 12:50

  8. TYPO3com voted on patch set 2 V +1 09/11/20, 12:52 Completed build in 11m 47s on Fri, 11 Sep, 12:52 PM Test Summary: 73208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5543

  9. TYPO3com voted on patch set 3 V +1 09/11/20, 12:58 Completed build in 11m 44s on Fri, 11 Sep, 12:58 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5544

  10. Björn Jacob voted on patch set 3 CR +1 09/11/20, 13:46

  11. Georg Ringer voted on patch set 3 V +2 CR +2 09/11/20, 17:37

  12. Georg Ringer merged patch set 4 09/11/20, 17:37