Review main Merged

65703[TASK] Do not set computed property _REAL_PID

Benni Mack CR +2 V +2 Easy +0 −7 updated 09/11/20, 17:36

Commit message

Since "pid=-1" is gone in TYPO3 v10, the "_REAL_PID"
value is not needed anymore and can be removed
in Workspace-related code.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 09/11/20, 12:14

  2. TYPO3com voted on patch set 1 V +1 09/11/20, 12:28 Completed build in 14m 23s on Fri, 11 Sep, 12:28 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5541

  3. Björn Jacob voted on patch set 1 CR +1 09/11/20, 12:41

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 09/11/20, 12:53

  5. Georg Ringer voted on patch set 1 V +2 CR +2 09/11/20, 17:36

  6. Georg Ringer merged patch set 2 09/11/20, 17:36