Review main Merged

65705[BUGFIX] Only fix versioning PID for moved records

Benni Mack CR +2 V +2 Hard +160 −133 updated 09/18/20, 18:46

Commit message

Since the removal of "pid=-1" in TYPO3 v10, it is not necessary
to fix the versioning PID for all versioned records anymore.

The checks in BackendUtility::fixVersioningPid() and
PageRepository->fixVersioningPid() are cleaned up, because:

* The only version type that has a DIFFERENT page ID than
its online pendant is the MOVE_POINTER (t3ver_state=4)
* The MOVE_PLACEHOLDER does not contain a t3ver_oid
and is not evaluated ever in these methods
* All other t3ver_state items have the same PID as the live
version, and should not be evaluated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 812

  1. Benni Mack uploaded patch set 1 09/11/20, 20:15

  2. TYPO3com voted on patch set 1 V -1 09/11/20, 20:30 Completed build in 14m 46s on Fri, 11 Sep, 08:30 PM Test Summary: 6 of 73694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5553

  3. Benni Mack uploaded patch set 2 09/11/20, 20:33

  4. TYPO3com voted on patch set 2 V +1 09/11/20, 20:46 Completed build in 13m 01s on Fri, 11 Sep, 08:46 PM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5554

  5. Benni Mack uploaded patch set 3 09/16/20, 07:39

  6. TYPO3com voted on patch set 3 V +1 09/16/20, 07:51 Completed build in 11m 50s on Wed, 16 Sep, 07:51 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5642

  7. Benni Mack uploaded patch set 4 09/16/20, 08:52

  8. TYPO3com voted on patch set 4 V +1 09/16/20, 09:06 Completed build in 13m 02s on Wed, 16 Sep, 09:06 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5643

  9. Oli Bartsch voted on patch set 4 V +1 CR +1 09/17/20, 08:27

  10. Christian Kuhn voted on patch set 4 V +1 CR +1 09/18/20, 17:18

  11. Benni Mack voted on patch set 4 V +2 CR +2 09/18/20, 18:46

  12. Benni Mack merged patch set 5 09/18/20, 18:46