Review main Abandoned Breaking

65706[!!!][BUGFIX] Search: Consider the columns' visibility by record type

Daniel Windloff CR 0 V 0 Expert +1799 −294 updated 11/04/21, 13:04

Commit message

The purpose was to get rid of one of the remaining plain SQL
occurrences in the `getQueryBuilder` in `DatabaseRecordList`.
That is the prerequisite to introduce the current table in all SQL
statements in that method.
That in turn is a basis for bugfixes in the sorting area, because they
need to join tables. Therefore, the columns' config `search`.`andWhere`
has been removed.

The point of the `andWhere` configuration was to add a possibility to
hide columns in the search, if they are not visible in a record type.
When evaluating that approach it turns out, that it works only
theoretically. In practice, for every column, that is in the search
field list, must be checked if it is visible in every type of the
record. If not, the `andWhere` configuration should have been added.
The result of the former approach are a bunch of miss configurations
in the tca.
In the search results columns were accidentally considered or
accidentally not considered.

That's why the visibility of a search column should be determined
based on the `type` configuration.
As the types configuration holds a bunch of options, only the most
frequent used ones, the `type` configuration itself and
`subtypes_addlist` configuration, are taken into account.
To add conditions for other display related configurations, the
hook should be used.

As the search in the DatabaseRecordList is used as a detail view of the
live search, the live search must be considered as well.
To add a source for the conditions of both searches, the
calculation of the search condition has been moved to a service class.
Both searches (Live search and the search in the DatabaseRecordList)
use this class to add the needed conditions.

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 14

Review log 58

  1. Daniel Windloff uploaded patch set 1 09/12/20, 07:30

  2. TYPO3com voted on patch set 1 V -1 09/12/20, 07:42 Completed build in 11m 39s on Sat, 12 Sep, 07:42 AM Test Summary: 73221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5555

  3. Daniel Windloff uploaded patch set 2 09/12/20, 08:02

  4. TYPO3com voted on patch set 2 V +1 09/12/20, 08:14 Completed build in 11m 21s on Sat, 12 Sep, 08:14 AM Test Summary: 73221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5556

  5. Daniel Windloff uploaded patch set 3 09/19/20, 06:51

  6. TYPO3com voted on patch set 3 V +1 09/19/20, 07:05 Completed build in 13m 02s on Sat, 19 Sep, 07:05 AM Test Summary: 73668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5737

  7. Christian Kuhn commented on patch set 3 11/04/21, 13:01

    Hey. I hope it's ok to abandon this one for now: Nothing happened for quite a while and the current patch version has various non-trivial merge-conflicts - especially since a lot of other things happened meanwhile in the list module. It's of course good to pick this up again, we may want to coordinate the visibility questions beforehand, though.
  8. Christian Kuhn abandoned the change 11/04/21, 13:04