65706[!!!][BUGFIX] Search: Consider the columns' visibility by record type
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 3
Files 14
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+16 −150
- typo3/sysext/core/Classes/Migrations/TcaMigration.php+56 −0
- typo3/sysext/core/Classes/Preparations/TcaPreparation.php+4 −13
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92296-TCAColumnConfigSearchAndWhereSettingDropped.rstnew+36 −0
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+157 −0
- typo3/sysext/core/Tests/Unit/Preparations/TcaPreparationTest.php+0 −6
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −6
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+5 −119
- typo3/sysext/recordlist/Classes/Search/SearchConditionService.phpnew+290 −0
- typo3/sysext/recordlist/Tests/Functional/Search/Fixtures/Extensions/searchconditiontest/Configuration/TCA/tx_searchconditiontest_tt_content.phpnew+955 −0
- typo3/sysext/recordlist/Tests/Functional/Search/Fixtures/Extensions/searchconditiontest/ext_emconf.phpnew+21 −0
- typo3/sysext/recordlist/Tests/Functional/Search/Fixtures/Extensions/searchconditiontest/ext_tables.sqlnew+29 −0
- typo3/sysext/recordlist/Tests/Functional/Search/Fixtures/searchconditiontest.csvnew+24 −0
- typo3/sysext/recordlist/Tests/Functional/Search/SearchConditionServiceTest.phpnew+206 −0
Review log 58
-
Daniel Windloff uploaded patch set 1 09/12/20, 07:30
-
TYPO3com voted on patch set 1 V -1 09/12/20, 07:42 Completed build in 11m 39s on Sat, 12 Sep, 07:42 AM Test Summary: 73221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5555
-
Daniel Windloff uploaded patch set 2 09/12/20, 08:02
-
TYPO3com voted on patch set 2 V +1 09/12/20, 08:14 Completed build in 11m 21s on Sat, 12 Sep, 08:14 AM Test Summary: 73221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5556
-
Daniel Windloff uploaded patch set 3 09/19/20, 06:51
-
TYPO3com voted on patch set 3 V +1 09/19/20, 07:05 Completed build in 13m 02s on Sat, 19 Sep, 07:05 AM Test Summary: 73668 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5737
-
Christian Kuhn commented on patch set 3 11/04/21, 13:01
Hey. I hope it's ok to abandon this one for now: Nothing happened for quite a while and the current patch version has various non-trivial merge-conflicts - especially since a lot of other things happened meanwhile in the list module. It's of course good to pick this up again, we may want to coordinate the visibility questions beforehand, though. -
Christian Kuhn abandoned the change 11/04/21, 13:04