65707[FEATURE] Make it possible to exclude links from link checking
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/master/Feature-92297-MakeItPossibleToExcludeLinksFromLinkCheckingInRTE.rstnew+58 −0
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php+5 −0
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/input_content_with_broken_link_nolinkcheck.xmlnew+13 −0
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+7 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yamlnew+10 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Plugins.yaml+2 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Default.yaml+1 −0
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/nolinkcheck/styles/nolinkcheck.cssnew+14 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/nolinkcheck/plugin.jsnew+34 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/showbrokenlinks/styles/showbrokenlinks.css+1 −0
Review log 911
-
Sybille Peters uploaded patch set 1 09/12/20, 18:01
-
TYPO3com voted on patch set 1 V +1 09/12/20, 18:12 Completed build in 10m 55s on Sat, 12 Sep, 06:12 PM Test Summary: 73212 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5561
-
Sybille Peters uploaded patch set 2 09/20/20, 14:14
-
TYPO3com voted on patch set 2 V +1 09/20/20, 14:26 Completed build in 11m 25s on Sun, 20 Sep, 02:26 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5762
-
Oli Bartsch commented on patch set 2 CR -1 09/21/20, 07:15
Generally I like the idea to exclude specific links form checking but using a class which actually is only be used for frontend styling doesn't suite here well I think. The class is displayed in the frontend without any further treatment. What do you think about adding a new link attribute field like "Exclude linkchecking" as checkbox and using it in the LinkBrowser in general not only for RTE? -
Sybille Peters commented on patch set 2 09/21/20, 07:49
> Patch Set 2: Code-Review-1 > > Generally I like the idea to exclude specific links form checking but using a class which actually is only be used for frontend styling doesn't suite here well I think. The class is displayed in the frontend without any further treatment. > > What do you think about adding a new link attribute field like "Exclude linkchecking" as checkbox and using it in the LinkBrowser in general not only for RTE? My idea was originally to use a standard that is also respected by other link checkers (e.g. https://www.deadlinkchecker.com/). Something similar to adding "noindex", "nofollow" as hints for search engines. And being able to add that for the entire page and for individual links. I did not find such a standard, I am hoping we may be able to establish such a standard ourselves. In that case, the property should get rendered in the frontend as well. (I know we are not there yet, but one can plan for the future, right?). I am not set on using "class". I admit it was a "lazy" solution and it would probably be a better solution to add a dedicated attribute for this. So, I agree with your suggestion there, but disagree that it should not be rendered in FE. What do you propose the resulting HTML should look like? -
Oli Bartsch commented on patch set 2 09/22/20, 06:53
> Patch Set 2: > > > Patch Set 2: Code-Review-1 > > > > Generally I like the idea to exclude specific links form checking but using a class which actually is only be used for frontend styling doesn't suite here well I think. The class is displayed in the frontend without any further treatment. > > > > What do you think about adding a new link attribute field like "Exclude linkchecking" as checkbox and using it in the LinkBrowser in general not only for RTE? > > My idea was originally to use a standard that is also respected by other link checkers (e.g. https://www.deadlinkchecker.com/). Something similar to adding "noindex", "nofollow" as hints for search engines. And being able to add that for the entire page and for individual links. I did not find such a standard, I am hoping we may be able to establish such a standard ourselves. In that case, the property should get rendered in the frontend as well. (I know we are not there yet, but one can plan for the future, right?). > > I am not set on using "class". I admit it was a "lazy" solution and it would probably be a better solution to add a dedicated attribute for this. > > So, I agree with your suggestion there, but disagree that it should not be rendered in FE. > > What do you propose the resulting HTML should look like? All right understand your idea. As there is currently no such attribute available (see: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a), I think we have to go with the class for now. -
Georg Ringer commented on patch set 2 CR -1 09/22/20, 08:19
I really don't like using the class approach. Furthermore this must be set to each and every link if a domain has issues with checking. IMO a new setting in the extension settings would be more suitable with more advantages: * a domain needs to be set only once * version control can be used * the setting can be deployed -
Sybille Peters commented on patch set 2 09/22/20, 13:02
> Patch Set 2: Code-Review-1 > > I really don't like using the class approach. Furthermore this must be set to each and every link if a domain has issues with checking. IMO a new setting in the extension settings would be more suitable with more advantages: > > * a domain needs to be set only once > * version control can be used > * the setting can be deployed I think we should also make it possible to exclude URLs in the central configuration. I am already working on a patch for that. The reason I started this patch - this would make it possible to give the control to the editor. Right now it is really frustrating to work with linkvalidator if you have a lot of these falsely reported links. Even if we make it possible to configure them away, it will probably be something you need at least admin rights for. If you are an editor and have a lazy administrator - you still have the problem. Another idea I have (3) is quite elegant but more costly: Create an ignore button in the list of broken links which will add the URL to the ignore list (ideally with possibility to choose full URL or partial URL, e.g. domain). That way you could give this possibility to the editors but make it configurable if they have the permissions to do this. It would also be possible to make this into a suggestion which has to be approved. Downside is the table has to be queried. What do you do if this bloats up? Do you load them all into memory? etc. So, to sum it up: I have these ideas, see https://forge.typo3.org/issues/92297 1) this patch 2) configure exclude URLs in current configuration (page TSconfig) 3) ignore URLs list which you can add to from list of URLs (as DB table). Must also be possible to edit this. 4) additionally: do not treat 403 as errors by default (also configurable) -
Georg Ringer commented on patch set 2 09/22/20, 13:50
> So, to sum it up: I have these ideas, see https://forge.typo3.org/issues/92297 > > 1) this patch > 2) configure exclude URLs in current configuration (page TSconfig) > 3) ignore URLs list which you can add to from list of URLs (as DB table). Must also be possible to edit this. > 4) additionally: do not treat 403 as errors by default (also configurable) I would suggest writing some drafts before coding and discuss that in coredev or via decisions.typo3.org and I like 3 the most, followed by 2 -
Sybille Peters abandoned the change 10/15/20, 11:30
See comments: Reviewers downvoted and other ways to implement this should be pursued.