Review main Abandoned

65709[TASK] Revert "[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core DependencyInjection"

Benjamin Franzke CR 0 V 0 Easy +4 −8 updated 10/06/20, 14:38

Commit message

This reverts commit d70c568a96d88b6bdbd7c7d98e75b293eef7911c.

Package argument of ServiceProviderRegistry::create()
was changed to PackageInterface, but the method
getServiceProvider() that is called on that argument
is not available on the interface, therefore
Package is declared as type by intent.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 78

  1. Benjamin Franzke uploaded patch set 1 09/13/20, 04:58

  2. TYPO3com voted on patch set 1 V +1 09/13/20, 05:11 Completed build in 12m 33s on Sun, 13 Sep, 05:11 AM Test Summary: 73208 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5569

  3. Daniel Goerz commented on patch set 1 09/13/20, 13:54

    ContainerBuilder.php:153 Unresolved

    We dont want to revert this actually, so do we make a "clean" revert and another patch that just fixes this or do we just want to fix the Interface issue here?
  4. Alexander Schnitzler commented on patch set 1 09/14/20, 07:51

    Said it on the other patch already: If the interface doesn't define the api but the implementation, changing the interface is no breaking change since it cannot be used by people to replace the core implementation. Why not fix the interface then and have a proper interface and implementation?
  5. Sascha Egerer commented on patch set 1 09/14/20, 12:57

    > Patch Set 1: > > Said it on the other patch already: If the interface doesn't define the api but the implementation, changing the interface is no breaking change since it cannot be used by people to replace the core implementation. Why not fix the interface then and have a proper interface and implementation? +1 for adjusting the interface as the interface is used everywhere else and also already in that method in `$package = $this->packageManager->getPackage($packageKey);` So we don't really break anything that was not broken before.
  6. Sascha Egerer commented on patch set 1 CR -1 09/14/20, 12:58

    ServiceProviderRegistry.php:116 Unresolved

    Even if i would keep it as PackageInterface `|null` is missing in the param definition and should be added in another patchset
  7. Daniel Goerz commented on patch set 1 CR -2 10/06/20, 14:05

    We are going to just "revert" the type hint and follow up with an interface change if we agree on it. Once the BUGFIX is merged, I will abandon this revert. https://review.typo3.org/c/Packages/TYPO3.CMS/+/66057
  8. Daniel Goerz abandoned the change 10/06/20, 14:38