Review 9.5 Merged

65711[BUGFIX] Deliver detected file type for IM identify

Helmut Hummel CR +2 V +2 Normal +70 −27 updated 09/17/20, 11:38

Commit message

Although not used in TYPO3 Core directly, the identify
command by ImageMagick now delivers the file extension
from IM plus the file type identified by IM as well.

This saves some regexp magic, and a foreach() loop,
as the "-format" output delivers proper IM results.

While previously this change was only targeted
for master, it is now backported to 9.5 because
otherwise https://review.typo3.org/65277 causes
a regression when indexing PDF files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Georg Ringer +1
    • Sybille Peters +1
    • Daniel Sattler +1
    • TYPO3com +1 CI

Issues 3

Files 2

Review log 1014

  1. Helmut Hummel uploaded patch set 1 09/13/20, 12:40

  2. Helmut Hummel updated the commit message in patch set 2 09/13/20, 12:41

  3. Helmut Hummel updated the commit message in patch set 3 09/13/20, 12:44

  4. Helmut Hummel uploaded patch set 4 09/13/20, 12:45

  5. TYPO3com voted on patch set 1 V +1 09/13/20, 12:54 Completed build in 13m 29s on Sun, 13 Sep, 12:54 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-797

  6. TYPO3com voted on patch set 2 V -1 09/13/20, 12:56 Completed build in 14m 51s on Sun, 13 Sep, 12:56 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-798

  7. TYPO3com voted on patch set 3 V +1 09/13/20, 13:01 Completed build in 13m 43s on Sun, 13 Sep, 01:01 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-799

  8. TYPO3com commented on patch set 4 09/13/20, 13:05 Completed build in 17m 20s on Sun, 13 Sep, 01:05 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-800

  9. Sybille Peters voted on patch set 4 V +1 09/14/20, 13:15

  10. Daniel Sattler voted on patch set 4 V +1 09/16/20, 15:33

  11. Georg Ringer voted on patch set 4 V +1 CR +1 09/17/20, 05:47

  12. Benni Mack voted on patch set 4 CR +2 09/17/20, 10:04

  13. Helmut Hummel voted on patch set 4 V +2 09/17/20, 11:38

  14. Helmut Hummel merged patch set 5 09/17/20, 11:38