Review 10.4 Merged

65717[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Domain

Benni Mack CR +2 V +2 Easy +2 −2 updated 09/11/20, 10:33

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 09/11/20, 09:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/11/20, 09:55 Completed build in 11m 32s on Fri, 11 Sep, 09:55 AM Test Summary: 74202 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-395

  3. Oliver Klee voted on patch set 1 CR +1 09/11/20, 10:01

  4. Benni Mack voted on patch set 1 V +2 CR +2 09/11/20, 10:32

  5. Benni Mack merged patch set 2 09/11/20, 10:33