Review 10.4 Merged

65719[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core DependencyInjection

Benni Mack CR +2 V +2 Easy +8 −4 updated 09/12/20, 19:13

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 09/12/20, 18:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/12/20, 18:57 Completed build in 12m 51s on Sat, 12 Sep, 06:57 PM Test Summary: 74280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-399

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/12/20, 19:13

  4. Benni Mack merged patch set 2 09/12/20, 19:13