Review 10.4 Merged

65728[BUGFIX] Prevent toggling of child containers controls

Benni Mack CR +2 V +2 Easy +5 −4 updated 09/22/20, 14:32

Commit message

The toggleContainerControls method of InlineControlContainer.ts now
only toggles its immediate controls. Furthermore, the new record link
control for creating inline records has gotten the required class to
toggle its visibility, when reaching maxitems limit.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack commented on patch set 1 09/18/20, 07:39

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js
  2. Benni Mack commented on patch set 1 09/18/20, 07:40

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 09/18/20, 07:51 Completed build in 11m 48s on Fri, 18 Sep, 07:51 AM Test Summary: 11 of 74810 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-416

  4. Nikita Hovratov uploaded patch set 2 09/18/20, 08:25

  5. TYPO3com voted on patch set 2 V +1 09/18/20, 08:37 Completed build in 11m 59s on Fri, 18 Sep, 08:37 AM Test Summary: 74324 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-417

  6. Benni Mack commented on patch set 2 V -1 09/18/20, 15:11

    conflict
  7. Nikita Hovratov rebased onto patch set 3 09/21/20, 18:32

  8. TYPO3com voted on patch set 3 V +1 09/21/20, 18:44 Completed build in 11m 26s on Mon, 21 Sep, 06:44 PM Test Summary: 74702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-448

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 09/22/20, 14:05

  10. Georg Ringer voted on patch set 3 V +2 CR +2 09/22/20, 14:32

  11. Georg Ringer merged patch set 4 09/22/20, 14:32