Review 10.4 Merged

65729[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Localization

Daniel Goerz CR +2 V +2 Easy +14 −5 updated 09/19/20, 12:26

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Daniel Goerz commented on patch set 1 09/18/20, 12:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 09/18/20, 12:53 Completed build in 11m 31s on Fri, 18 Sep, 12:53 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-419

  3. Daniel Goerz uploaded patch set 2 09/18/20, 13:21

  4. TYPO3com voted on patch set 2 V +1 09/18/20, 13:34 Completed build in 12m 57s on Fri, 18 Sep, 01:34 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-420

  5. Oliver Klee voted on patch set 2 CR +1 09/18/20, 14:25

  6. Daniel Goerz voted on patch set 2 V +2 CR +2 09/19/20, 12:26

  7. Daniel Goerz merged patch set 3 09/19/20, 12:26