Review main Merged

65733[BUGFIX] Add missing language option to EmailToSender

Oli Bartsch CR +2 V +2 Easy +43 −0 updated 09/22/20, 07:04

Commit message

The EmailFinisher class evaluates the defined "translation language"
which can be used to define the language of the mail content
independent of the current frontend language. The corresponding
option is however missing in the EmailToSender configuration.

This leads to side effects if e.g. EmailToReceiver is configured with
this option before EmailToSender. The EmailToSender finisher then
automatically also uses this language without any possibility to
prevent this behaviour.

Therefore the missing configuration option for defining a
translation language is now also available in the EmailToSender
finisher configuration like already claimed in the documentation.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Oli Bartsch uploaded patch set 1 09/14/20, 09:45

  2. TYPO3com voted on patch set 1 V +1 09/14/20, 09:56 Completed build in 10m 56s on Mon, 14 Sep, 09:56 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5592

  3. Benni Mack voted on patch set 1 V +1 CR +1 09/21/20, 07:40

  4. Georg Ringer voted on patch set 1 V +2 CR +2 09/22/20, 07:04

  5. Georg Ringer merged patch set 2 09/22/20, 07:04