Review main Merged

65734[BUGFIX] Check allowTagsOutside in RteHtmlParser

tobiasulber CR +2 V +2 Easy +15 −3 updated 12/03/21, 16:09

Commit message

The RTE tsconfig option allowTagsOutside is now
considered, when deciding whether to wrap a tag
inside a paragraph.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Benni Mack +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 2336

Show 711 earlier messages
  1. tobiasulber uploaded patch set 1 09/14/20, 09:57

  2. TYPO3com voted on patch set 1 V -1 09/14/20, 09:58 Completed build in 29s on Mon, 14 Sep, 09:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5593

  3. tobiasulber updated the commit message in patch set 2 09/14/20, 10:00

  4. TYPO3com voted on patch set 2 V -1 09/14/20, 10:00 Completed build in 22s on Mon, 14 Sep, 10:00 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5594

  5. tobiasulber abandoned the change 09/14/20, 18:04

    not a good solution I'll add a better one
  6. tobiasulber restored the change 09/14/20, 18:25

  7. tobiasulber commented on patch set 3 09/14/20, 18:27

    Published edit on patch set 2.
  8. tobiasulber updated the commit message in patch set 4 09/14/20, 18:29

  9. TYPO3com voted on patch set 3 V +1 09/14/20, 18:40 Completed build in 11m 55s on Mon, 14 Sep, 06:40 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5610

  10. TYPO3com voted on patch set 4 V +1 09/14/20, 18:49 Completed build in 18m 58s on Mon, 14 Sep, 06:49 PM Test Summary: 73239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5611

  11. Benni Mack rebased onto patch set 5 11/04/21, 12:08

  1. core-ci voted on patch set 5 V +1 11/04/21, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18875

  2. Anja Leichsenring updated the commit message in patch set 6 11/16/21, 07:05

  3. Anja Leichsenring voted on patch set 6 V +1 CR +1 11/16/21, 07:05

  4. core-ci voted on patch set 6 V +1 11/16/21, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19346

  5. Oli Bartsch commented on patch set 6 11/16/21, 11:02

    RteHtmlParser.php:670

    Could we please use speaking names for new variables?
  6. tobiasulber commented on patch set 7 11/16/21, 11:09

    Published edit on patch set 6.
  7. tobiasulber commented on patch set 8 11/16/21, 11:10

    Published edit on patch set 7.
  8. core-ci voted on patch set 7 V -1 11/16/21, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19354

  9. core-ci voted on patch set 8 V +1 11/16/21, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19355

  10. Benni Mack updated the commit message in patch set 9 11/18/21, 10:49

  11. core-ci voted on patch set 9 V +1 11/18/21, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19479

  12. Benni Mack wrote 11/29/21, 10:18

    Change destination moved from master to main
  13. Benni Mack updated the commit message in patch set 10 11/29/21, 14:07

  14. core-ci voted on patch set 10 V +1 11/29/21, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20094

  15. Nikita Hovratov uploaded patch set 11 12/01/21, 16:49

  16. Nikita Hovratov commented on patch set 11 12/01/21, 16:49

    RteHtmlParser.php:670 Reply

    Done
  17. core-ci voted on patch set 11 V -1 12/01/21, 17:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20344

  18. Nikita Hovratov rebased onto patch set 12 12/01/21, 20:00

  19. core-ci voted on patch set 12 V +1 12/01/21, 20:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20357

  20. Benni Mack uploaded patch set 13 12/03/21, 15:38

  21. Benni Mack voted on patch set 13 V +1 CR +1 12/03/21, 15:39

  22. core-ci voted on patch set 13 V +1 12/03/21, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20509

  23. Nikita Hovratov voted on patch set 13 V +1 CR +1 12/03/21, 16:02

  24. Benni Mack voted on patch set 13 V +2 CR +2 12/03/21, 16:09

  25. Benni Mack merged patch set 14 12/03/21, 16:09