Review main Merged

65738[BUGFIX] Show fieldname of flexform fields

Georg Ringer CR +2 V +2 Easy +3 −0 updated 09/16/20, 07:00

Commit message

Since #83461 the name of the field is rendered next to the label for
administrator users if debug mode is enabled. Now also the name of
flexform fields is rendered.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Georg Ringer uploaded patch set 1 09/14/20, 21:21

  2. Georg Ringer commented on patch set 1 09/14/20, 21:22

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 09/14/20, 21:40 Completed build in 18m 09s on Mon, 14 Sep, 09:40 PM Test Summary: 73238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5617

  4. Oli Bartsch commented on patch set 1 09/15/20, 07:02

    Works as advertised. However isn't it a FEATURE rather than a TASK?
  5. Sybille Peters commented on patch set 1 09/15/20, 07:24

    > Patch Set 1: > > Works as advertised. However isn't it a FEATURE rather than a TASK? I also would not see it as a task. It's not really anything new because it just adds an already existing feature to flexforms too. But still, it could be propagated as feature. Also, you could argue, that it finishes what was already started by adding the labels for Flexforms too, that might let it qualify as bugfix. Just my 2c.
  6. Sybille Peters voted on patch set 1 V +1 CR +1 09/15/20, 07:26

  7. Benni Mack updated the commit message in patch set 2 09/16/20, 06:20

  8. Benni Mack commented on patch set 2 V +1 CR +1 09/16/20, 06:21

    to me, this isn't a feature, but something that was forgotten when adding the initial feature. Thus, it's a fix
  9. TYPO3com voted on patch set 2 V -1 09/16/20, 06:31 Completed build in 11m 16s on Wed, 16 Sep, 06:31 AM Test Summary: 73272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5640

  10. Oli Bartsch commented on patch set 2 V +1 CR +1 09/16/20, 06:35

    > Patch Set 2: Verified+1 Code-Review+1 > > to me, this isn't a feature, but something that was forgotten when adding the initial feature. Thus, it's a fix All right.
  11. TYPO3com voted on patch set 2 V +1 09/16/20, 06:47 Completed build in 11m 13s on Wed, 16 Sep, 06:47 AM Test Summary: 73272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5641

  12. Benni Mack voted on patch set 2 V +2 CR +2 09/16/20, 07:00

  13. Benni Mack merged patch set 3 09/16/20, 07:00