65742[BUGFIX] Do not use optional method arguments before required arguments
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Georg Ringer +1
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+3 −3
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+1 −1
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+1 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+1 −1
- typo3/sysext/indexed_search/Classes/Domain/Repository/AdministrationRepository.php+1 −1
- typo3/sysext/sys_note/Classes/Hook/PageHook.php+2 −2
- typo3/sysext/workspaces/Classes/Dependency/DependencyEntityFactory.php+2 −2
- typo3/sysext/workspaces/Classes/Dependency/EventCallback.php+1 −1
Review log 911
-
Benni Mack uploaded patch set 1 09/15/20, 12:12
-
Mathias Brodala commented on patch set 1 09/15/20, 12:21
I don't think it is a good idea to backport these changes to v10 since we technically have method signature changes. -
TYPO3com voted on patch set 1 V +1 09/15/20, 12:25 Completed build in 11m 36s on Tue, 15 Sep, 12:24 PM Test Summary: 73272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5629
-
Benni Mack commented on patch set 1 09/15/20, 12:25
> Patch Set 1: > > (1 comment)Reply
sure, but then 10.4 will never have proper PHP 8.0 support. We could just target master for now and fix it there, and then see how bad PHP 8.0 still will be in the future once the dependencies are straightened out (e.g. Doctrine DBAL 2 + PHP 8.0 is currently bad). As alternative, we could backport only the changes for internal + tests classes, and protected methods? -
Mathias Brodala commented on patch set 1 09/15/20, 12:27
Reply Unresolved
I think the first option makes sense, especially if we know that not even dependencies of TYPO3 are fully compatible yet. Once that has been sorted out it can be reviewed/discussed once more if v10 should get support for PHP 8. -
Benni Mack updated the commit message in patch set 2 09/15/20, 12:54
-
TYPO3com voted on patch set 2 V +1 09/15/20, 13:05 Completed build in 10m 55s on Tue, 15 Sep, 01:05 PM Test Summary: 73272 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5633
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/16/20, 07:11
-
Christian Kuhn voted on patch set 2 V +1 CR +1 09/18/20, 19:35
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 09/18/20, 19:35
-
Anja Leichsenring merged patch set 3 09/18/20, 19:35