Review main Merged

65747[BUGFIX] Allow longer values in index_stat_word

Ingo Fabbri CR +2 V +2 Easy +1 −1 updated 09/17/20, 13:21

Commit message

A varchar length of 30 seems not enough for uncommon search words.
This limit gets hit quite frequently - especially when the word contains
one or multiple UTF-8 escape sequences.
Increase it to allow up to 50 characters - keep safe with index length.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Mathias Schreiber +1
    • Oliver Klee +1
    • Bernhard Berger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 913

  1. Ingo Fabbri uploaded patch set 1 09/17/20, 07:31

  2. TYPO3com voted on patch set 1 V +1 09/17/20, 07:47 Completed build in 16m 37s on Thu, 17 Sep, 07:47 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5652

  3. Ingo Fabbri updated the commit message in patch set 2 09/17/20, 08:21

  4. Ingo Fabbri uploaded patch set 3 09/17/20, 08:28

  5. Ingo Fabbri updated the commit message in patch set 4 09/17/20, 08:31

  6. Bernhard Berger commented on patch set 4 CR +1 09/17/20, 08:38

    Seems reasonable and looks good to me.
  7. TYPO3com voted on patch set 2 V +1 09/17/20, 08:39 Completed build in 15m 47s on Thu, 17 Sep, 08:39 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5659

  8. TYPO3com voted on patch set 3 V -1 09/17/20, 09:01 Completed build in 23m 39s on Thu, 17 Sep, 09:01 AM Test Summary: 1 of 73761 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5662

  9. TYPO3com voted on patch set 4 V +1 09/17/20, 09:08 Completed build in 29m 09s on Thu, 17 Sep, 09:08 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5664

  10. Oliver Klee voted on patch set 4 CR +1 09/17/20, 11:29

  11. Mathias Schreiber commented on patch set 4 V +1 CR +1 09/17/20, 12:41

    no brainer and non intrusive
  12. Benni Mack voted on patch set 4 V +2 CR +2 09/17/20, 13:21

  13. Benni Mack merged patch set 5 09/17/20, 13:21