65748[BUGFIX] Remove pre-checks on "transport_spool_filepath"
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Bernhard Berger +1
- Benni Mack +1
-
Verified V +2 Done
- Daniel Goerz +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 812
-
Ingo Fabbri uploaded patch set 1 09/17/20, 08:00
-
TYPO3com voted on patch set 1 V +1 09/17/20, 08:12 Completed build in 11m 57s on Thu, 17 Sep, 08:12 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5655
-
Ingo Fabbri uploaded patch set 2 09/17/20, 08:21
-
Ingo Fabbri rebased onto patch set 3 09/17/20, 08:28
-
Ingo Fabbri uploaded patch set 4 09/17/20, 08:31
-
TYPO3com commented on patch set 2 09/17/20, 08:43 Completed build in 20m 14s on Thu, 17 Sep, 08:43 AM Test Summary: 73274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5660
-
Bernhard Berger commented on patch set 4 CR +1 09/17/20, 08:55
I agree that the removed checks in the patch set make sense. Looking at the line below: `$spool = GeneralUtility::makeInstance(FileSpool::class, $path);` the FileSpool has an internal check if the file exists and calls an `mkdir_deep` if the path needs to be created. This patch removes unneccesary redundancy. Having seen TYPO3 instances almost die from file operations on `glusterfs` and `nfs` storages in k8n/OpenShift setups I agree that it makes sense to minimize redundand file system checks. -
TYPO3com voted on patch set 3 V +1 09/17/20, 09:01 Completed build in 23m 34s on Thu, 17 Sep, 09:01 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5663
-
TYPO3com commented on patch set 4 09/17/20, 09:13 Completed build in 34m 06s on Thu, 17 Sep, 09:13 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5665
-
Benni Mack voted on patch set 4 V +1 CR +1 09/21/20, 07:53
-
Daniel Goerz voted on patch set 4 V +2 CR +2 09/21/20, 12:35
-
Daniel Goerz merged patch set 5 09/21/20, 12:35