Review main Merged

65748[BUGFIX] Remove pre-checks on "transport_spool_filepath"

Ingo Fabbri CR +2 V +2 Easy +2 −2 updated 09/21/20, 12:35

Commit message

FileSpool uses GeneralUtility::mkdir_deep() if path does not exist.
mkdir_deep() also tries to fix permissions.
Even if this fails, there are further writable-checks down the line
in \TYPO3\CMS\Core\Mail\FileSpool constructor.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Bernhard Berger +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Ingo Fabbri uploaded patch set 1 09/17/20, 08:00

  2. TYPO3com voted on patch set 1 V +1 09/17/20, 08:12 Completed build in 11m 57s on Thu, 17 Sep, 08:12 AM Test Summary: 73287 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5655

  3. Ingo Fabbri uploaded patch set 2 09/17/20, 08:21

  4. Ingo Fabbri rebased onto patch set 3 09/17/20, 08:28

  5. Ingo Fabbri uploaded patch set 4 09/17/20, 08:31

  6. TYPO3com commented on patch set 2 09/17/20, 08:43 Completed build in 20m 14s on Thu, 17 Sep, 08:43 AM Test Summary: 73274 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5660

  7. Bernhard Berger commented on patch set 4 CR +1 09/17/20, 08:55

    I agree that the removed checks in the patch set make sense. Looking at the line below: `$spool = GeneralUtility::makeInstance(FileSpool::class, $path);` the FileSpool has an internal check if the file exists and calls an `mkdir_deep` if the path needs to be created. This patch removes unneccesary redundancy. Having seen TYPO3 instances almost die from file operations on `glusterfs` and `nfs` storages in k8n/OpenShift setups I agree that it makes sense to minimize redundand file system checks.
  8. TYPO3com voted on patch set 3 V +1 09/17/20, 09:01 Completed build in 23m 34s on Thu, 17 Sep, 09:01 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5663

  9. TYPO3com commented on patch set 4 09/17/20, 09:13 Completed build in 34m 06s on Thu, 17 Sep, 09:13 AM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5665

  10. Benni Mack voted on patch set 4 V +1 CR +1 09/21/20, 07:53

  11. Daniel Goerz voted on patch set 4 V +2 CR +2 09/21/20, 12:35

  12. Daniel Goerz merged patch set 5 09/21/20, 12:35