Review main Merged

65750[TASK] Remove rector/rector from require-dev section

Anja Leichsenring CR +2 V +2 Hard +176 −219 updated 09/18/20, 11:35

Commit message

used commands:
   composer remove rector/rector --no-update-with-dependencies

The groundwork to use rector as a integrity check is not yet done.
In order to remove a dependency from the set, the package is removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Simon Gilli +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Simon Gilli +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 1521

  1. Anja Leichsenring uploaded patch set 1 09/17/20, 15:10

  2. Simon Gilli commented on patch set 1 CR -1 09/17/20, 15:21

    There are too many deps changed. That's because of the `composer req` used here. Instead you should run `composer req pkg --no-update` and afterwards `composer update pkg`. Not sure if `remove` has the same side effects. If you like I can fix it for you...
  3. TYPO3com voted on patch set 1 V +1 09/17/20, 15:22 Completed build in 11m 10s on Thu, 17 Sep, 03:22 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5680

  4. Anja Leichsenring uploaded patch set 2 09/17/20, 15:38

  5. Simon Gilli commented on patch set 2 CR -1 09/17/20, 15:46

    The removed package is not removed from the lock file and the new one not added. Did you run `composer update rector/rector-prefixed` afterwards? Can't see it in the commit message either...
  6. TYPO3com voted on patch set 2 V +1 09/17/20, 15:49 Completed build in 10m 48s on Thu, 17 Sep, 03:49 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5681

  7. Simon Gilli commented on patch set 2 09/17/20, 15:50

    > Patch Set 2: Code-Review-1 > > The removed package is not removed from the lock file and the new one not added. Did you run `composer update rector/rector-prefixed` afterwards? Can't see it in the commit message either... Try to use `--no-update-with-dependencies` for the remove command
  8. Anja Leichsenring uploaded patch set 3 09/17/20, 15:56

  9. Simon Gilli commented on patch set 3 V +1 CR +1 09/17/20, 15:59

    Perfect!
  10. Anja Leichsenring commented on patch set 3 09/17/20, 16:06

    > Patch Set 3: Verified+1 Code-Review+1 > > Perfect! thanks, that was due to your great guidance.
  11. TYPO3com voted on patch set 3 V +1 09/17/20, 16:07 Completed build in 10m 55s on Thu, 17 Sep, 04:07 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5682

  12. Anja Leichsenring commented on patch set 3 V -1 09/17/20, 16:49

    let's remove the whole package and config for now. This was more like work in progress and requires the phpstan conversions to be further evolved before it is needed again.
  13. Anja Leichsenring uploaded patch set 4 09/17/20, 16:54

  14. TYPO3com voted on patch set 4 V +1 09/17/20, 17:05 Completed build in 11m 00s on Thu, 17 Sep, 05:05 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5685

  15. Simon Gilli voted on patch set 4 V +1 CR +1 09/17/20, 18:04

  16. Richard Haeser commented on patch set 4 V +1 CR +1 09/18/20, 08:05

    It works fine, but as I'm not sure about implications, someone else (which do know about the implications) can merge this one
  17. TYPO3com voted on patch set 4 V -1 09/18/20, 08:13 Completed build in 05m 36s on Fri, 18 Sep, 08:13 AM Test Summary: 3 of 94003 failed Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-42

  18. Anja Leichsenring commented on patch set 4 09/18/20, 08:40

    > Patch Set 4: Verified-1 > > Completed build in 05m 36s on Fri, 18 Sep, 08:13 AM > Test Summary: 3 of 94003 failed > Find logs and detail information at https://bamboo.typo3.com/browse/TB-GTN-42 this is only a test bed run, please ignore
  19. TYPO3com voted on patch set 4 V +1 09/18/20, 09:01 Completed build in 18m 31s on Fri, 18 Sep, 09:01 AM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5710

  20. Anja Leichsenring voted on patch set 4 V +2 CR +2 09/18/20, 11:35

  21. Anja Leichsenring merged patch set 5 09/18/20, 11:35