Review 10.4 Merged

65751[TASK] Omit composer install before composer update for test builds

Anja Leichsenring CR +2 V +2 Easy +0 −2 updated 09/18/20, 16:49

Commit message

The install command might hide failing updates, causing the whole
run to support as successful, even if it was not. The installation
will be fine also without previous composer install.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Anja Leichsenring uploaded patch set 1 09/17/20, 16:38

  2. TYPO3com voted on patch set 1 V +1 09/17/20, 16:50 Completed build in 11m 44s on Thu, 17 Sep, 04:50 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-410

  3. Simon Gilli voted on patch set 1 V +1 CR +1 09/17/20, 16:50

  4. Richard Haeser commented on patch set 1 CR +1 09/18/20, 08:06

    Don't know how I can verify this, but +1 for code review
  5. Christian Kuhn voted on patch set 1 V +2 CR +2 09/18/20, 16:49

  6. Christian Kuhn merged patch set 2 09/18/20, 16:49