65754[TASK] Ensure composer update installs the highest possible packages
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1114
-
Anja Leichsenring uploaded patch set 1 09/17/20, 18:23
-
Anja Leichsenring commented on patch set 1 CR -2 09/17/20, 18:23
this needs to become green before merging -
TYPO3com voted on patch set 1 V +1 09/17/20, 18:34 Completed build in 11m 02s on Thu, 17 Sep, 06:34 PM Test Summary: 73275 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5690
-
Simon Gilli commented on patch set 1 09/17/20, 18:45
Great! A little typo in the commit message only...Unresolved
little typo "alway" -
Anja Leichsenring commented on patch set 1 09/17/20, 18:51
> Patch Set 1: > > (1 comment) > > Great! A little typo in the commit message only... ups :) Will fix with next push, thanks for spotting. -
Simon Gilli commented on patch set 1 09/18/20, 11:05
Just a little site note for the future. The rest looks fine!AbstractCoreSpec.java:1991UnresolvedThis look error-prone but would need a complete refactor of the phpVersion string. Instead of a string we should use constants which could be converted to the needed strings, some type of array constant with the first constant as key. But this is a bigger work and I'm fine if you put this onto your task list for the moment... -
Anja Leichsenring uploaded patch set 2 10/02/20, 15:50
-
TYPO3com voted on patch set 2 V -1 10/02/20, 17:04 Completed build in 54m 51s on Fri, 2 Oct, 05:04 PM Test Summary: 1 of 74220 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6214
-
Andreas Kienast uploaded patch set 3 10/08/20, 12:08
-
TYPO3com voted on patch set 3 V +1 10/08/20, 12:28 Completed build in 15m 28s on Thu, 8 Oct, 12:28 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6364
-
Anja Leichsenring voted on patch set 3 CR 0 10/19/20, 17:10
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/19/20, 17:24
-
Andreas Kienast voted on patch set 3 V +2 CR +2 10/20/20, 05:32
-
Andreas Kienast merged patch set 4 10/20/20, 05:32