65755[BUGFIX] Allow access to a sub-branch of a workspace for a limited user
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Danilo Caccialanza +1
-
Verified V +2 Done
- Benni Mack +2
- cbugada +1
- Danilo Caccialanza +1
- TYPO3com +1 CI
Issues 2
Files 1
Review log 2330
Show 45 earlier messages
-
Danilo Caccialanza uploaded patch set 1 09/17/20, 18:36
-
TYPO3com voted on patch set 1 V -1 09/17/20, 18:37 Completed build in 25s on Thu, 17 Sep, 06:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5693
-
Danilo Caccialanza voted on patch set 1 V +1 09/17/20, 18:44
-
Danilo Caccialanza wrote 09/23/20, 12:17
Removed reviewer Gianluca Strafella. -
Danilo Caccialanza wrote 09/23/20, 12:18
Hashtag added: workspaces
-
Danilo Caccialanza wrote 09/23/20, 12:18
Topic set to workspaces -
Benni Mack commented on patch set 1 09/23/20, 14:28
BackendUserAuthentication.php:2025UnresolvedI think we should use BackendUtility::BEgetRootline() instead. -
Danilo Caccialanza uploaded patch set 2 09/24/20, 15:57
-
TYPO3com voted on patch set 2 V -1 09/24/20, 15:58 Completed build in 23s on Thu, 24 Sep, 03:58 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5920
-
Danilo Caccialanza uploaded patch set 3 10/06/20, 16:02
-
TYPO3com voted on patch set 3 V -1 10/06/20, 16:18 Completed build in 15m 21s on Tue, 6 Oct, 04:18 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6289
-
Danilo Caccialanza uploaded patch set 4 10/06/20, 16:36
-
TYPO3com voted on patch set 4 V +1 10/06/20, 16:51 Completed build in 14m 57s on Tue, 6 Oct, 04:51 PM Test Summary: 73785 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6292
-
Danilo Caccialanza commented on patch set 4 V +1 CR +1 10/06/20, 16:55
I use this patch in an environment with "complex workspace configurations" and everything works. -
cbugada voted on patch set 4 V +1 10/07/20, 07:31
-
Benni Mack commented on patch set 4 10/07/20, 08:27
BackendUserAuthentication.php:2023Unresolvedyou set $readPerms='1=1' and now check on !$readPerms. Does not make sense to me... -
Benni Mack voted on patch set 4 CR -1 10/07/20, 08:27
-
Danilo Caccialanza uploaded patch set 5 10/07/20, 11:05
-
TYPO3com voted on patch set 5 V -1 10/07/20, 11:05 Completed build in 27s on Wed, 7 Oct, 11:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6319
-
Danilo Caccialanza uploaded patch set 6 10/07/20, 11:10
-
TYPO3com voted on patch set 6 V +1 10/07/20, 11:28 Completed build in 17m 56s on Wed, 7 Oct, 11:28 AM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6320
-
Benni Mack uploaded patch set 7 10/08/20, 12:20
-
Benni Mack commented on patch set 7 10/08/20, 12:21
Hey Danilo, can you please re-check if my changes still work with your installation? Had to clean the variables and the logic up to make the code more readable,. -
TYPO3com voted on patch set 7 V +1 10/08/20, 12:50 Completed build in 21m 10s on Thu, 8 Oct, 12:50 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6365
-
Danilo Caccialanza commented on patch set 7 10/08/20, 13:12
> Patch Set 7: > > Hey Danilo, > > can you please re-check if my changes still work with your installation? Had to clean the variables and the logic up to make the code more readable,. Yes tested on 11.0.0-dev and 10.4.9 in my installation with many users (ca. 200), pages (ca. 14'000), workspaces (10) with "admin user", "advancede user", "limitede user" and it works! Thanks so much for this help :) -
Danilo Caccialanza commented on patch set 7 V +1 CR +1 10/08/20, 13:24
> Patch Set 7: > > > Patch Set 7: > > > > Hey Danilo, > > > > can you please re-check if my changes still work with your installation? Had to clean the variables and the logic up to make the code more readable,. > > Yes tested on 11.0.0-dev and 10.4.9 in my installation with many users (ca. 200), pages (ca. 14'000), workspaces (10) with "admin user", "advancede user", "limitede user" and it works! > Thanks so much for this help :) -
cbugada voted on patch set 7 V +1 CR +1 10/08/20, 13:34
-
cbugada wrote 10/08/20, 13:45
Removed Code-Review+1 by cbugada <christian.bugada@ti.ch> -
Benni Mack voted on patch set 7 V +2 CR +2 10/22/20, 11:34
-
Benni Mack merged patch set 8 10/22/20, 11:34