Review 10.4 Abandoned

65756[BUGFIX] Fix ObjectAccess::isPropertyGettable for ArrayAccess objects

Anja Leichsenring CR 0 V 0 Normal +40 −11 updated 11/01/20, 07:50

Commit message

While introducing symfony/property-access, method isPropertyGettable
of class ObjectAccess had been adjusted in a manner which made the
mixed usage of array access and regular property access impossible.

If an object implemented ArrayAccess and used regular properties,
all of those properties were reported inacessible/non-gettable which
is not true.

With this patch, regular properties and those defined magically
via ArrayAccess are detected correctly as gettable.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 912

  1. Anja Leichsenring uploaded patch set 1 09/17/20, 19:01

  2. TYPO3com voted on patch set 1 V -1 09/17/20, 19:16 Completed build in 12m 21s on Thu, 17 Sep, 07:16 PM Test Summary: 6 of 74816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-412

  3. Anja Leichsenring uploaded patch set 2 09/17/20, 19:18

  4. Anja Leichsenring commented on patch set 2 09/17/20, 19:19

    manual backport, I adjusted the two tests in deprecated unit tests. Those demonstrate changed behavior. Do we accept it as such?
  5. TYPO3com voted on patch set 2 V +1 09/17/20, 19:38 Completed build in 17m 07s on Thu, 17 Sep, 07:38 PM Test Summary: 74331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-414

  6. Christian Kuhn updated the commit message in patch set 3 09/18/20, 16:52

  7. TYPO3com voted on patch set 3 V +1 09/18/20, 17:06 Completed build in 13m 09s on Fri, 18 Sep, 05:06 PM Test Summary: 74331 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-421

  8. Anja Leichsenring commented on patch set 3 CR -1 09/18/20, 18:27

    waiting for feedback, requested from Alex.
  9. Alexander Schnitzler commented on patch set 3 09/22/20, 18:57

    Hold it please. I will re-check master again. It's likely I missed a bug here.
  10. Alexander Schnitzler commented on patch set 3 09/23/20, 07:36

    > Patch Set 3: > > Hold it please. I will re-check master again. It's likely I missed a bug here. Alright, so the issue is that we have this patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/59331/) in master only. That one deprecated the forced access on properties via reflection. I would abandon this backport.
  11. Alexander Schnitzler voted on patch set 3 V -1 09/23/20, 07:36

  12. Anja Leichsenring abandoned the change 11/01/20, 07:50

    as Alex requested