Review 10.4 Merged

65757[BUGFIX] Set correct return type for CommandRegistry::getCommandByIdentifier

Georg Ringer CR +2 V +2 Easy +2 −2 updated 09/18/20, 19:45

Commit message

The method `getCommandByIdentifier` can return `null`, therefore the
return type must be adjusted.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Georg Ringer uploaded patch set 1 09/17/20, 19:19

  2. Georg Ringer commented on patch set 1 09/17/20, 19:19

    This change is ready for review.
  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 09/17/20, 19:22

  4. TYPO3com voted on patch set 1 V +1 09/17/20, 19:42 Completed build in 21m 03s on Thu, 17 Sep, 07:42 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-415

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 09/17/20, 20:07

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 09/18/20, 19:45

  7. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/18/20, 19:45

  8. Anja Leichsenring merged patch set 2 09/18/20, 19:45