Review main Merged

65758[FEATURE] Add textWrap argument to f:link.typolink viewhelper

Johannes Rebhan CR +2 V +2 Normal +63 −1 updated 01/18/21, 22:23

Commit message

This adds the ability to wrap the content of an automatically
generated typolink link text, e.g. when linking to internal pages,
with markup using the typolink options `wrap` and `ATagBeforeWrap`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 3444

Show 1419 earlier messages
  1. Johannes Rebhan uploaded patch set 1 09/18/20, 10:50

  2. TYPO3com voted on patch set 1 V -1 09/18/20, 10:51 Completed build in 31s on Fri, 18 Sep, 10:51 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5714

  3. Simon Gilli commented on patch set 1 CR -1 09/18/20, 11:24

    Thanks for your contribution! Please make sure you code according our CGL rules.

    TypolinkViewHelper.php:164 Unresolved

    Please add spaces around the (), this is why the tests are currently failing...
  4. Simon Gilli commented on patch set 1 09/18/20, 11:26

    Unresolved

    Why do you think this is a bug? FEATURE or TASK would be more suitable here

    Unresolved

    You are missing the release line here
  5. Simon Gilli commented on patch set 1 09/18/20, 11:28

    @benni what do you say, feature or task?
  6. Simon Gilli updated the commit message in patch set 2 09/18/20, 14:59

  7. Simon Gilli commented on patch set 3 09/18/20, 15:00

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 2 V -1 09/18/20, 15:00 Completed build in 27s on Fri, 18 Sep, 03:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5721

  9. Oliver Klee commented on patch set 3 09/18/20, 15:03

    Is this really only a change (TASK), or is this a new FEATURE that should be announced as such?
  10. Simon Gilli commented on patch set 3 09/18/20, 15:04

    Reply

    imho it's a feature. I asked Benni for his opinion here see comment above.
  11. Oliver Klee commented on patch set 3 09/18/20, 15:09

    Reply

    Ack
  12. TYPO3com voted on patch set 3 V +1 09/18/20, 15:13 Completed build in 12m 34s on Fri, 18 Sep, 03:13 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5722

  13. Simon Gilli updated the commit message in patch set 4 09/18/20, 15:28

  14. Simon Gilli commented on patch set 4 09/18/20, 15:30

    > Patch Set 3: > > (1 comment)

    Reply

    I changed it to a feature as we need a .rst to describe it anyway and asked the contributor to add a .rst properly.
  15. Simon Gilli commented on patch set 4 CR -1 09/18/20, 15:31

    The .rst is missing. Please describe your change there and how it could be used. Use the helper at https://forger.typo3.com/utilities/rst
  16. TYPO3com voted on patch set 4 V +1 09/18/20, 15:40 Completed build in 11m 40s on Fri, 18 Sep, 03:40 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5723

  17. Johannes Rebhan uploaded patch set 5 09/18/20, 16:39

  18. TYPO3com voted on patch set 5 V +1 09/18/20, 16:51 Completed build in 12m 15s on Fri, 18 Sep, 04:51 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5729

  19. Simon Gilli commented on patch set 5 CR -1 09/18/20, 17:00

    Please provide some tests to ensure the functionality does not get broken or removed.

    Feature-92338-ExtendTypolinkViewhelperLinkWraping.rst:12 Unresolved

  1. Oliver Klee wrote 09/18/20, 17:34

    Removed reviewer Oliver Klee.
  2. Benni Mack commented on patch set 5 09/21/20, 17:06

    Thanks for the patch, Johannes. what do you think about naming this property for fluid something like "textWrap" or "labelWrap"? "wrap" is so misleading in the TYPO3 world, as it could mean anything, and "ATagBeforeWrap" is one my worst-case scenarios where I always have to start thinking again what it was meant when reading the option. I'm fine using this option under-the-hood, just for the sake of the new fluid property, we could do it right.
  3. Johannes Rebhan commented on patch set 5 09/22/20, 10:50

    > Patch Set 5: > > Thanks for the patch, Johannes. > > what do you think about naming this property for fluid something like "textWrap" or "labelWrap"? "wrap" is so misleading in the TYPO3 world, as it could mean anything, and "ATagBeforeWrap" is one my worst-case scenarios where I always have to start thinking again what it was meant when reading the option. I'm fine using this option under-the-hood, just for the sake of the new fluid property, we could do it right. I first called it linkWrap, but then I didn't want to move away from the typoscript naming. But I have no strong opinion on this. textWrap sounds fine for me. Should I edit the commit?
  4. Johannes Rebhan uploaded patch set 6 09/24/20, 06:24

  5. TYPO3com voted on patch set 6 V +1 09/24/20, 06:35 Completed build in 11m 16s on Thu, 24 Sep, 06:35 AM Test Summary: 73705 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5909

  6. Benni Mack commented on patch set 6 CR +1 09/28/20, 08:14

    looks good.
  7. Philipp Parzer voted on patch set 6 CR +1 10/01/20, 19:00

  8. Simon Gilli voted on patch set 6 CR +1 12/08/20, 15:26

  9. Oli Bartsch uploaded patch set 7 01/05/21, 12:55

  10. TYPO3com voted on patch set 7 V -1 01/05/21, 13:04 Completed build in 09m 08s on Tue, 5 Jan, 01:04 PM Test Summary: 32195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8622

  11. TYPO3com voted on patch set 7 V +1 01/05/21, 13:21 Completed build in 34m 52s on Tue, 5 Jan, 01:21 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8622

  12. TYPO3com commented on patch set 7 01/05/21, 13:24 Completed build in 10m 01s on Tue, 5 Jan, 01:24 PM Test Summary: 32545 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8623

  13. Guido Schmechel commented on patch set 7 01/09/21, 13:35

    Basically everything fits here and it is spent correctly. One more question regarding the documentation: Should we add an example with an extra class? Escaping in particular might not be directly accessible to everyone? <f:link.typolink parameter="1" textWrap="<span class=\"my-class\">|</span>" />
  14. Oli Bartsch uploaded patch set 8 01/11/21, 08:59

  15. Oli Bartsch commented on patch set 8 01/11/21, 08:59

    Reply

    Yes, why not :)
  16. TYPO3com voted on patch set 8 V +1 01/11/21, 09:08 Completed build in 09m 35s on Mon, 11 Jan, 09:08 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8803

  17. Oli Bartsch commented on patch set 8 V -1 01/11/21, 09:54

    Will add the new option also to other link ViewHelpers.
  18. Oli Bartsch commented on patch set 8 V +1 CR +1 01/11/21, 10:39

    Reply

    Unfortunately not possible since the other ViewHelpers use UriBuilder which has no API to add arbitrary typolink configuration.
  19. Oliver Hader commented on patch set 8 CR -1 01/11/21, 11:55

    wait
  20. Oliver Hader commented on patch set 8 CR 0 01/11/21, 12:09

    I was looking for a way to keep the context of HTML and typoLink processing, e.g. having something like ``` <f:link.typolink parameter="123"> <span>{typolink.text}</span> </f:link.typolink> ``` Spoiler: It does not work since this view-helper bluntly uses just `stdWrap` returning a string...
  21. Benni Mack voted on patch set 8 V +2 CR +2 01/13/21, 13:52

  22. Benni Mack commented on patch set 8 01/13/21, 13:53

    Reply

    Ready for merge then?
  23. Guido Schmechel voted on patch set 8 V +1 01/16/21, 13:29

  24. Oliver Hader commented on patch set 8 CR +1 01/18/21, 22:23

    Reply

    Ack
  25. Oliver Hader merged patch set 9 01/18/21, 22:23