Review main Merged

65760[TASK] Remove scheduler task for redirects cleanup

Frank Nägler CR +2 V +2 Hard +1 −262 updated 09/18/20, 14:42

Commit message

The existing console command can also be executed as a
scheduler task, for this reason, we remove the scheduler task.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Gilli +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1013

  1. Frank Nägler uploaded patch set 1 09/18/20, 11:33

  2. Frank Nägler updated the commit message in patch set 2 09/18/20, 11:35

  3. TYPO3com voted on patch set 1 V +1 09/18/20, 11:45 Completed build in 11m 58s on Fri, 18 Sep, 11:45 AM Test Summary: 73279 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5716

  4. TYPO3com voted on patch set 2 V +1 09/18/20, 11:51 Completed build in 15m 26s on Fri, 18 Sep, 11:51 AM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5717

  5. Simon Gilli commented on patch set 2 09/18/20, 12:03

    Feature-91712-RedirectModuleCleanupSchedulerTask.rst:12

    Should be `has` as it's singular now. Before `have` would have been correct spelling.
  6. Simon Gilli commented on patch set 3 09/18/20, 12:23

    Published edit on patch set 2.
  7. Simon Gilli commented on patch set 3 09/18/20, 12:24

    > Patch Set 2: > > (1 comment)

    Feature-91712-RedirectModuleCleanupSchedulerTask.rst:12 Reply

    Done
  8. Simon Gilli voted on patch set 3 CR +1 09/18/20, 12:24

  9. TYPO3com voted on patch set 3 V +1 09/18/20, 12:34 Completed build in 11m 40s on Fri, 18 Sep, 12:34 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5719

  10. Oliver Klee voted on patch set 3 CR +1 09/18/20, 12:39

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 09/18/20, 13:42

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 09/18/20, 14:42

  13. Andreas Kienast merged patch set 4 09/18/20, 14:42