Review 10.4 Merged

65761[TASK] Remove rector/rector from require-dev section

Anja Leichsenring CR +2 V +2 Hard +1 −288 updated 09/18/20, 17:04

Commit message

used commands:
   composer remove rector/rector --no-update-with-dependencies

The groundwork to use rector as a integrity check is not yet done.
In order to remove a dependency from the set, the package is removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 56

  1. Anja Leichsenring uploaded patch set 1 09/18/20, 11:42

  2. TYPO3com voted on patch set 1 V +1 09/18/20, 11:54 Completed build in 11m 44s on Fri, 18 Sep, 11:54 AM Test Summary: 74323 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-418

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/18/20, 11:58

  4. Anja Leichsenring merged patch set 2 09/18/20, 11:58

  5. Simon Gilli commented on patch set 1 V +1 CR +1 09/18/20, 11:59

    Only one little thing: the removal of the fundings, I guess you deleted your vendor folder in the meantime?
  6. Anja Leichsenring commented on patch set 2 09/18/20, 17:04

    > Patch Set 1: Verified+1 Code-Review+1 > > Only one little thing: the removal of the fundings, I guess you deleted your vendor folder in the meantime? exactly :) I followed Helmuts advise, and again it was not perfect. I decided to ignore it.