Review main Abandoned

65763[FEATURE] Add stdWrap processing of settings in Extbase and FLUIDTEMPLATE

Thorben Nissen CR 0 V 0 Normal +73 −1 updated 09/23/20, 13:31

Commit message

The Extbase ActionController and the FLUIDTEMPLATE content object are now
processing the settings recursively and apply stdWrap processing if a
setting has the `.stdWrap` property set.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 67

  1. Thorben Nissen uploaded patch set 1 09/18/20, 15:45

  2. TYPO3com voted on patch set 1 V +1 09/18/20, 16:00 Completed build in 14m 37s on Fri, 18 Sep, 04:00 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5725

  3. Oli Bartsch commented on patch set 1 CR -1 09/18/20, 17:47

    Please provide a feature rst for this. Also tests would be great.
  4. Josef Glatz commented on patch set 1 V -1 09/23/20, 08:13

    What about using only variables, where you have the full amount of stdWrap functionality?
  5. Alexander Schnitzler commented on patch set 1 09/23/20, 08:53

    tbh I dislike this approach as much as I dislike using typoscript for the configuration at all because typoscript can be changed depending on a lot of circumstances. I believe that this clutters the settings and makes it hard to debug why things are configured the way they are because in the worst case you have to check all typoscript files and all typoscript in the database. My understanding of configuration is quite different actually. It's pretty much the idea of putting dedicated values into a plugin and then adjust your logic depending on them. It's pretty much like the idea of ts constants which cannot be altered with stdWrap and such and which are then passed into typoscript functions. Likewise, the settings we put into plugins should be static IMHO. In the past 3 years I already implemented a couple of changes which replaces typoscript config with php/yaml/whatever just to be sure that configuration which should be global cannot be altered depending on typoscript conditions. Plugins aren't global, hence their configuration mustn't. But, the configuration should be defined once and not be altered by typoscript which has another scope. The thing that comes closest to that idea is flexforms which make the plugin configuration immutable during the request.
  6. Thorben Nissen commented on patch set 1 09/23/20, 11:44

    @Alexander: Thanks for explaining your concerns. I think you're quite right about the configuration should not change part. My actual goal was to allow to pass some typoscript generated values into the plugin/template to be able to render things depending on data outside the plugin. In my case I wanted to render a headline as <h1> or <h2> depending on cObj:parentRecordNumber. I will try a different approach using variables instead of settings. I think we can abandon this change.
  7. Thorben Nissen abandoned the change 09/23/20, 13:31

    Configurations (which settings are) should not be dynamic in that way as explained by Alexander Schnitzler.