Review main Merged

65764[FEATURE] Make label of bookmarkGroups translatable

Oli Bartsch CR +2 V +2 Easy +33 −1 updated 09/18/20, 19:40

Commit message

Add possibility to use language labels as value for the
user TSconfig `options.bookmarkGroups` option.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Tiefenbrunn +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 911

  1. Oli Bartsch uploaded patch set 1 09/18/20, 16:10

  2. Oli Bartsch commented on patch set 1 09/18/20, 16:11

    FYI hsc is applied in Line 441.
  3. Christian Kuhn commented on patch set 1 09/18/20, 16:15

    Feature-92337-MakeLabelOfBookmarkGroupsTranslatable.rst:4

    Remember the .rst files are no commit message. They shouldn't state what happened, but what is possible now. A better title would be: "New TSconfig options to translate bookmark groups"
  4. TYPO3com voted on patch set 1 V +1 09/18/20, 16:24 Completed build in 13m 56s on Fri, 18 Sep, 04:24 PM Test Summary: 73281 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5726

  5. Oli Bartsch uploaded patch set 2 09/18/20, 16:32

  6. TYPO3com voted on patch set 2 V +1 09/18/20, 16:45 Completed build in 12m 18s on Fri, 18 Sep, 04:45 PM Test Summary: 73280 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5728

  7. Oli Bartsch commented on patch set 2 09/18/20, 16:56

    Feature-92337-MakeLabelOfBookmarkGroupsTranslatable.rst:4 Reply

    Done
  8. Georg Tiefenbrunn voted on patch set 2 CR +1 09/18/20, 18:53

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 09/18/20, 19:39

  10. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/18/20, 19:40

  11. Anja Leichsenring merged patch set 3 09/18/20, 19:40