Review main Merged

65767[BUGFIX] Skip sys_refindex for workspace placeholders

Christian Kuhn CR +2 V +2 Hard +11 −356 updated 09/19/20, 16:12

Commit message

The reference index can be seen as a cache for relations.
It is used in various places to show how many other records
have a relation to a given record, for instance in list
and filelist module and in the record info modal.

In workspaces, new and moved records create records pairs:
t3ver_state -1 & 1 and t3ver_state 3 & 4. The backend
always shows only one of these pairs. The reference index
creates an entry for each record, so two for each pair.
This is useless and confusing for editors: If for instance
a new file reference is added to a content element in
workspaces, the file list shows two usages of the file
instead of only one.

The patch suppresses reference index entries for the
placeholder records - t3ver_state 1 and 3 - so each pair
ends up with only one sys_refindex entry.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 95

Show 75 more files

Review log 812

  1. Christian Kuhn uploaded patch set 1 09/18/20, 22:08

  2. TYPO3com voted on patch set 1 V -1 09/18/20, 22:19 Completed build in 10m 59s on Fri, 18 Sep, 10:19 PM Test Summary: 275 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5733

  3. Christian Kuhn uploaded patch set 2 09/19/20, 10:20

  4. Christian Kuhn uploaded patch set 3 09/19/20, 10:29

  5. TYPO3com voted on patch set 2 V +1 09/19/20, 10:33 Completed build in 13m 22s on Sat, 19 Sep, 10:33 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5742

  6. TYPO3com voted on patch set 3 V -1 09/19/20, 10:42 Completed build in 13m 13s on Sat, 19 Sep, 10:42 AM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5743

  7. Christian Kuhn updated the commit message in patch set 4 09/19/20, 10:54

  8. TYPO3com voted on patch set 4 V +1 09/19/20, 11:05 Completed build in 11m 09s on Sat, 19 Sep, 11:05 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5744

  9. Oli Bartsch voted on patch set 4 CR +1 09/19/20, 11:31

  10. Oli Bartsch voted on patch set 4 V +1 09/19/20, 14:50

  11. Daniel Goerz voted on patch set 4 V +2 CR +2 09/19/20, 16:12

  12. Daniel Goerz merged patch set 5 09/19/20, 16:12