Review main Merged

65768[BUGFIX] Prevent usage of non existing php function in PHP 7.2 tests

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 09/19/20, 07:55

Commit message

The function in question is array_key_first, which was introduced with
PHP 7.3.0. It is not available for PHP 7.2 testing, so a workaround
was introduced.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Anja Leichsenring uploaded patch set 1 09/19/20, 06:43

  2. Anja Leichsenring uploaded patch set 2 09/19/20, 06:48

  3. TYPO3com voted on patch set 1 V +1 09/19/20, 06:54 Completed build in 11m 46s on Sat, 19 Sep, 06:54 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5735

  4. TYPO3com voted on patch set 2 V +1 09/19/20, 07:00 Completed build in 12m 36s on Sat, 19 Sep, 07:00 AM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5736

  5. Georg Ringer voted on patch set 2 V +1 CR +1 09/19/20, 07:00

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 09/19/20, 07:35

  7. Björn Jacob voted on patch set 2 V +1 CR +1 09/19/20, 07:49

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 09/19/20, 07:54

  9. Christian Kuhn merged patch set 3 09/19/20, 07:55