Review main Merged

65770[TASK] Enable EXT:impexp to include presets in export

Alexander Nitsche CR +2 V +2 Normal +165 −6 updated 11/11/20, 20:58

Commit message

Only tables with TCA configurations are available for the export of a
TYPO3 instance. The stored export configurations - so called presets -
were missing the TCA configuration and thus had to be exported and
imported separately in a database client.

This patch adds a TCA configuration for the export configurations and
thus makes them exportable and importable along with the main dump.
The presets are saved on PID=0 and hidden from record lists to
force the user to continue managing them with the export module.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • Markus Klein +1
    • Rémy DANIEL +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 3853

Show 1928 earlier messages
  1. Alexander Nitsche uploaded patch set 1 09/19/20, 13:47

  2. Alexander Nitsche commented on patch set 1 09/19/20, 13:50

    Hi Simon, thanks for having a look at it. As soon as you agree on the overall approach i would like to add a functional test in the end as well. Greetings, Alex
  3. TYPO3com voted on patch set 1 V +1 09/19/20, 13:59 Completed build in 11m 09s on Sat, 19 Sep, 01:59 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5745

  4. Simon Gilli commented on patch set 1 09/19/20, 14:42

    Looks fine so far.
    Please add a longer description here to explain what this patch exactly does e.g. adding TCA defs.
  5. Simon Gilli commented on patch set 1 09/19/20, 14:43

    > Patch Set 1: > > Hi Simon, thanks for having a look at it. As soon as you agree on the overall approach i would like to add a functional test in the end as well. Greetings, Alex I guess there is not much to test except the repository. Perhaps some functional to check the table is now available to select...
  6. Alexander Nitsche uploaded patch set 2 09/20/20, 11:25

  7. TYPO3com voted on patch set 2 V +1 09/20/20, 11:38 Completed build in 12m 04s on Sun, 20 Sep, 11:38 AM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5757

  8. Alexander Nitsche updated the commit message in patch set 3 09/20/20, 11:40

  9. Alexander Nitsche commented on patch set 3 09/20/20, 11:51

    > Patch Set 1: > I guess there is not much to test except the repository. Perhaps some functional to check the table is now available to select... Added exactly that functional test.

    Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 09/20/20, 11:53 Completed build in 12m 05s on Sun, 20 Sep, 11:53 AM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5758

  11. Alexander Nitsche updated the commit message in patch set 4 09/20/20, 12:31

  12. TYPO3com voted on patch set 4 V +1 09/20/20, 12:43 Completed build in 11m 29s on Sun, 20 Sep, 12:43 PM Test Summary: 73661 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5760

  13. Georg Ringer commented on patch set 4 CR -1 09/28/20, 07:32

    locallang_tca.xlf:6 Unresolved

    please also provide attribute "resname"

    ExportControllerTest.php:3 Unresolved

    declare strict types
  14. Alexander Nitsche uploaded patch set 5 09/28/20, 08:27

  15. TYPO3com voted on patch set 5 V +1 09/28/20, 08:47 Completed build in 15m 56s on Mon, 28 Sep, 08:47 AM Test Summary: 73706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6034

  16. Alexander Nitsche uploaded patch set 6 09/29/20, 12:34

  17. TYPO3com voted on patch set 6 V +1 09/29/20, 12:46 Completed build in 12m 25s on Tue, 29 Sep, 12:46 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6065

  18. Markus Klein commented on patch set 6 09/30/20, 08:45

    Does that work for non-admin users as well?
  19. Alexander Nitsche commented on patch set 6 09/30/20, 09:03

    > Patch Set 6: > > Does that work for non-admin users as well? Yes. They cannot edit the presets records via Web > List as they are usually stored in PID=0, but they can load and save them in the export module as usual.
  20. Oli Bartsch commented on patch set 6 09/30/20, 09:06

    PresetRepository.php:39

    Maybe let's just instantiate in line 123 as it's only used once in this class.

    tx_impexp_presets.php:81

    Indentation looks a bit odd compared to other configurations like sys_news or sys_category.

    tx_impexp_presets.php:88

    Would suggest not declaring empty config arrays.

    locallang_csh_tx_impexp_presets.xlf:16

    Think about using a more positiv sentence like: "Please only edit if you know what you are doing."
  21. Alexander Nitsche uploaded patch set 7 09/30/20, 09:24

  22. Alexander Nitsche commented on patch set 7 09/30/20, 09:32

    Thanks for your feedback.

    PresetRepository.php:39 Reply

    Ok.

    tx_impexp_presets.php:81 Reply

    Right. This was a copy & paste side effect.

    tx_impexp_presets.php:88 Reply

    Changed. This was copied from sys_file.php.

    locallang_csh_tx_impexp_presets.xlf:16 Reply

    Changed with friendly support by deepl.com.
  23. TYPO3com voted on patch set 7 V -1 09/30/20, 09:46 Completed build in 21m 37s on Wed, 30 Sep, 09:46 AM Test Summary: 73019 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6087

  24. Oli Bartsch voted on patch set 7 CR +1 09/30/20, 09:53

  25. TYPO3com voted on patch set 7 V +1 09/30/20, 10:05 Completed build in 1h 01m 48s on Wed, 30 Sep, 10:05 AM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6087

  26. TYPO3com commented on patch set 7 09/30/20, 10:12 Completed build in 21m 17s on Wed, 30 Sep, 10:12 AM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6090

  27. Georg Ringer voted on patch set 7 V +1 CR +1 09/30/20, 13:26

  28. Simon Gilli voted on patch set 7 CR +1 09/30/20, 14:31

  1. Markus Klein commented on patch set 7 09/30/20, 18:44

    tx_impexp_presets.php:79

    no need to make this string 1. Use number 0, for simplicity. (string array keys being a number will be converted to a number by PHP anyways)

    ExportControllerTest.php:30

    I suggest shorting of names here.

    ext_tables.sql:5

    can be removed too, because will be created by Core due to settings cruser_id
  2. Markus Klein commented on patch set 8 09/30/20, 18:46

    Published edit on patch set 7.
  3. TYPO3com voted on patch set 8 V -1 09/30/20, 18:58 Completed build in 11m 16s on Wed, 30 Sep, 06:58 PM Test Summary: 1 of 74178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6103

  4. TYPO3com commented on patch set 7 09/30/20, 19:25 Completed build in 15m 45s on Wed, 30 Sep, 07:25 PM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6104

  5. TYPO3com voted on patch set 8 V +1 09/30/20, 19:31 Completed build in 21m 14s on Wed, 30 Sep, 07:31 PM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6105

  6. Alexander Nitsche commented on patch set 8 10/01/20, 10:29

    Thanks for your review and patch. I tested the changes and confirm that the database changes are still backwards compatible.

    tx_impexp_presets.php:79 Reply

    Ok.

    ExportControllerTest.php:30 Reply

    Ok.

    ext_tables.sql:5 Reply

    Nice. And it remains backwards compatible.
  7. Alexander Nitsche uploaded patch set 9 10/01/20, 10:34

  8. TYPO3com voted on patch set 9 V +1 10/01/20, 10:46 Completed build in 12m 00s on Thu, 1 Oct, 10:46 AM Test Summary: 73693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6117

  9. Simon Gilli voted on patch set 9 CR +1 10/01/20, 11:02

  10. Benni Mack commented on patch set 9 10/01/20, 13:36

    Since this is now a TCA table, we should/would consider: * Permission Handling (create/update possibly done via DataHandler?) * RootLevel Restrictions in TCA (what "pid" should be used) * Reference Index (table should probably excluded IMHO)
  11. Sybille Peters commented on patch set 9 10/02/20, 09:35

    Shouldn't this be a feature and include a changelog? (We had that before in another patch which was also declared as TASK and where it was pointed out and changed to BUGFIX. And it seems to be the way to go now to avoid the "this is a feature but we have a feature freeze in 10.4" dilemma.) I find this is messy. Also, do you really want to document this under "Distribution" in "TYPO3 Explained"? https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/issues/999 I think the impexp should rather have it's own documentation inside the system extension Documentation folder.
  12. Rémy DANIEL commented on patch set 9 10/02/20, 09:59

    I am agree with Benni: since the table is now with a TCA, the DataHandler should be used by the PresetRepository for inserting/updating the impexp preset. Actually if I edit the preset within impexp, the records history is not maintained, the permission are not checked, etc. But they are if I edit the record with the list module.

    tx_impexp_presets.php:6 Unresolved

    I would set `'rootlevel' => 1` because this record must be stored only on pid=0

    tx_impexp_presets.php:12 Unresolved

    A hidden field does not make sense in BE. You can drop it.

    tx_impexp_presets.php:45 Unresolved

    I would set `'type' => 'passthrough'` for `user_uid`, `item_uid` and especially the serialized field `preset_data`, which should not be edited through the TCE form.
  13. Alexander Nitsche commented on patch set 9 10/02/20, 10:19

    Hi, i moved the latest comments for ongoing discussions to the forge issue at https://forge.typo3.org/issues/92346 .
  14. Alexander Nitsche uploaded patch set 10 10/05/20, 16:45

  15. TYPO3com voted on patch set 10 V +1 10/05/20, 17:01 Completed build in 15m 37s on Mon, 5 Oct, 05:01 PM Test Summary: 73746 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6244

  16. Markus Klein voted on patch set 10 CR +1 10/06/20, 06:41

  17. Alexander Nitsche uploaded patch set 11 10/06/20, 06:59

  18. Markus Klein commented on patch set 11 CR +1 10/06/20, 07:08

    Thanks for the update and the TCA fix, I totally overlooked that with my last vote. (shame on me)
  19. TYPO3com voted on patch set 11 V +1 10/06/20, 07:25 Completed build in 22m 32s on Tue, 6 Oct, 07:25 AM Test Summary: 73746 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6257

  20. Rémy DANIEL voted on patch set 11 V +1 10/06/20, 07:38

  21. Rémy DANIEL wrote 10/06/20, 07:38

    Removed Verified+1 by Rémy DANIEL <dogawaf@no-log.org>
  22. Rémy DANIEL voted on patch set 11 CR +1 10/06/20, 07:38

  23. Georg Ringer voted on patch set 11 V +1 CR +1 10/06/20, 07:39

  24. Anja Leichsenring voted on patch set 11 V +2 CR +2 11/11/20, 20:58

  25. Anja Leichsenring merged patch set 12 11/11/20, 20:58