Review main Merged

65771[BUGFIX] Correct sys_refindex update on workspace publish

Christian Kuhn CR +2 V +2 Hard +350 −391 updated 09/20/20, 08:59

Commit message

When publishing workspace changes to live, many
sys_refindex rows are not updated properly, especially
if dealing with workspace-new or workspace-moved rows
and relations.

To update the reference index for relations, the data handler
uses class ReferenceIndex, which uses class RelationHandler,
which uses PlainDataResolver. All of these classes are
workspace aware and pick the current user workspace if
not explicitely told otherwise.

When publishing records, a given user is currently in some
workspace, but the reference index needs to be fixed for
live. This explicit runtime workspace switch is lost in
the ReferenceIndex.

The patch hands over given workspace context from
ReferenceIndex to RelationHandler during publish.

This one-liner fixes tons of broken reference index cases.
It also reveals a couple of still missing entries. Those
will be tackled with another patch.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 103

Show 83 more files

Review log 916

  1. Christian Kuhn uploaded patch set 1 09/19/20, 16:00

  2. TYPO3com voted on patch set 1 V -1 09/19/20, 16:11 Completed build in 10m 45s on Sat, 19 Sep, 04:11 PM Test Summary: 303 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5746

  3. Christian Kuhn uploaded patch set 2 09/19/20, 19:48

  4. TYPO3com voted on patch set 2 V -1 09/19/20, 20:00 Completed build in 11m 27s on Sat, 19 Sep, 08:00 PM Test Summary: 150 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5750

  5. Christian Kuhn uploaded patch set 3 09/19/20, 21:26

  6. TYPO3com voted on patch set 3 V +1 09/19/20, 21:42 Completed build in 16m 30s on Sat, 19 Sep, 09:42 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5751

  7. Christian Kuhn updated the commit message in patch set 4 09/19/20, 22:14

  8. Christian Kuhn uploaded patch set 5 09/19/20, 22:24

  9. TYPO3com voted on patch set 4 V +1 09/19/20, 22:28 Completed build in 14m 23s on Sat, 19 Sep, 10:28 PM Test Summary: 73658 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5752

  10. Christian Kuhn updated the commit message in patch set 6 09/19/20, 22:29

  11. TYPO3com voted on patch set 5 V -1 09/19/20, 22:37 Completed build in 13m 35s on Sat, 19 Sep, 10:37 PM Test Summary: 73307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5753

  12. TYPO3com voted on patch set 6 V -1 09/19/20, 22:44 Completed build in 15m 14s on Sat, 19 Sep, 10:44 PM Test Summary: 2 of 74143 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5754

  13. TYPO3com voted on patch set 6 V +1 09/19/20, 22:50 Completed build in 36m 01s on Sat, 19 Sep, 10:50 PM Test Summary: 73657 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5754

  14. Andreas Kienast voted on patch set 6 V +1 CR +1 09/20/20, 06:51

  15. Anja Leichsenring voted on patch set 6 V +2 CR +2 09/20/20, 08:59

  16. Anja Leichsenring merged patch set 7 09/20/20, 08:59