Review 10.4 Merged

65772[BUGFIX] Only fix versioning PID for moved records

Benni Mack CR +2 V +2 Hard +160 −133 updated 09/18/20, 20:01

Commit message

Since the removal of "pid=-1" in TYPO3 v10, it is not necessary
to fix the versioning PID for all versioned records anymore.

The checks in BackendUtility::fixVersioningPid() and
PageRepository->fixVersioningPid() are cleaned up, because:

* The only version type that has a DIFFERENT page ID than
its online pendant is the MOVE_POINTER (t3ver_state=4)
* The MOVE_PLACEHOLDER does not contain a t3ver_oid
and is not evaluated ever in these methods
* All other t3ver_state items have the same PID as the live
version, and should not be evaluated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 34

  1. Benni Mack commented on patch set 1 09/18/20, 18:46

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/18/20, 18:59 Completed build in 13m 14s on Fri, 18 Sep, 06:59 PM Test Summary: 74325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-423

  3. Benni Mack voted on patch set 1 V +2 CR +2 09/18/20, 20:01

  4. Benni Mack merged patch set 2 09/18/20, 20:01