Review 10.4 Merged

65774[BUGFIX] Use correct variable to access language id of a column

Anja Leichsenring CR +2 V +2 Easy +4 −4 updated 09/18/20, 19:41

Commit message

The fluid based page module used a non existing
variable to access the language id of a column. This lead
to passing `NaN` as language id to the DataHandler when
moving a content element in the corresponding column.
Therefore the content element was actually moved to the
default column because of the changed language.

The template is now accessing the correct variable fetched from
the SiteLanguage object which makes moving content on translated
pages possible again.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Anja Leichsenring commented on patch set 1 09/18/20, 19:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/18/20, 19:37 Completed build in 11m 37s on Fri, 18 Sep, 07:37 PM Test Summary: 74702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-426

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/18/20, 19:40

  4. Anja Leichsenring merged patch set 2 09/18/20, 19:41