Review 10.4 Merged

65780[BUGFIX] Prevent usage of non existing php function in PHP 7.2 tests

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 09/19/20, 08:15

Commit message

The function in question is array_key_first, which was introduced with
PHP 7.3.0. It is not available for PHP 7.2 testing, so a workaround
was introduced.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn commented on patch set 1 09/19/20, 07:55

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/19/20, 08:08 Completed build in 13m 10s on Sat, 19 Sep, 08:08 AM Test Summary: 74702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-431

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/19/20, 08:14

  4. Christian Kuhn merged patch set 2 09/19/20, 08:15