Review 10.4 Merged

65782[BUGFIX] Skip sys_refindex for workspace placeholders

Daniel Goerz CR +2 V +2 Hard +11 −356 updated 09/19/20, 16:44

Commit message

The reference index can be seen as a cache for relations.
It is used in various places to show how many other records
have a relation to a given record, for instance in list
and filelist module and in the record info modal.

In workspaces, new and moved records create records pairs:
t3ver_state -1 & 1 and t3ver_state 3 & 4. The backend
always shows only one of these pairs. The reference index
creates an entry for each record, so two for each pair.
This is useless and confusing for editors: If for instance
a new file reference is added to a content element in
workspaces, the file list shows two usages of the file
instead of only one.

The patch suppresses reference index entries for the
placeholder records - t3ver_state 1 and 3 - so each pair
ends up with only one sys_refindex entry.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 2

Files 95

Show 75 more files

Review log 34

  1. Daniel Goerz commented on patch set 1 09/19/20, 16:13

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/19/20, 16:24 Completed build in 11m 01s on Sat, 19 Sep, 04:24 PM Test Summary: 74700 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-433

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 09/19/20, 16:44

  4. Christian Kuhn merged patch set 2 09/19/20, 16:44