Review 10.4 Merged

65787[BUGFIX] Correct sys_refindex update on workspace publish

Anja Leichsenring CR +2 V +2 Hard +350 −391 updated 09/20/20, 09:12

Commit message

When publishing workspace changes to live, many
sys_refindex rows are not updated properly, especially
if dealing with workspace-new or workspace-moved rows
and relations.

To update the reference index for relations, the data handler
uses class ReferenceIndex, which uses class RelationHandler,
which uses PlainDataResolver. All of these classes are
workspace aware and pick the current user workspace if
not explicitely told otherwise.

When publishing records, a given user is currently in some
workspace, but the reference index needs to be fixed for
live. This explicit runtime workspace switch is lost in
the ReferenceIndex.

The patch hands over given workspace context from
ReferenceIndex to RelationHandler during publish.

This one-liner fixes tons of broken reference index cases.
It also reveals a couple of still missing entries. Those
will be tackled with another patch.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 103

Show 83 more files

Review log 34

  1. Anja Leichsenring commented on patch set 1 09/20/20, 09:00

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/20/20, 09:11 Completed build in 11m 26s on Sun, 20 Sep, 09:11 AM Test Summary: 74701 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-438

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 09/20/20, 09:12

  4. Anja Leichsenring merged patch set 2 09/20/20, 09:12