Review 10.4 Merged

65791[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core ExpressionLanguage

Daniel Goerz CR +2 V +2 Easy +2 −2 updated 09/21/20, 12:26

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Daniel Goerz commented on patch set 1 09/21/20, 12:13

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 09/21/20, 12:25 Completed build in 11m 26s on Mon, 21 Sep, 12:25 PM Test Summary: 74702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-446

  3. Daniel Goerz voted on patch set 1 V +2 CR +2 09/21/20, 12:25

  4. Daniel Goerz merged patch set 2 09/21/20, 12:26