Review main Merged

65795[BUGFIX] Load dependencies of ImmediateActionElement dynamically

Andreas Kienast CR +2 V +2 Easy +21 −15 updated 12/29/20, 16:22

Commit message

The module ImmediateActionElement is used to render a defined custom
HTML tag triggering certain actions once it's rendered, like reloading
the module menu or the backend's topbar. To achieve this, it needs
functionality from the modules TYPO3.ModuleMenu.App.refreshMenu and
TYPO3.Backend.Topbar.refresh.

This module is loaded at a very early stage where those dependencies
cannot do anything meaningful as there is nothing to do, namely the
backend login, which causes JavaScript warnings and increases loading
time.

To relax the situation, the modules are now loaded dynamically when
required by using async functions.

In a perfect world, there would be some kind of a hooking system and no
hardcoded list of actions, but we're not there, yet.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Martin Kutschker +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Martin Kutschker +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1217

  1. Andreas Kienast uploaded patch set 1 09/20/20, 11:45

  2. Andreas Kienast commented on patch set 1 09/20/20, 11:47

    For v10 this needs some testing in old Edge.
  3. TYPO3com voted on patch set 1 V -1 09/20/20, 11:58 Completed build in 13m 04s on Sun, 20 Sep, 11:58 AM Test Summary: 4 of 74047 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5759

  4. Andreas Kienast commented on patch set 1 09/20/20, 14:14

    Hm, I fail to get the tests functional again, I always run into some timing issue. I definitely need support on this one.
  5. Benjamin Franzke uploaded patch set 2 12/28/20, 17:35

    Rebase on master
  6. TYPO3com voted on patch set 2 V -1 12/28/20, 17:47 Completed build in 11m 13s on Mon, 28 Dec, 05:47 PM Test Summary: 5 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8476

  7. Benjamin Franzke commented on patch set 2 12/28/20, 18:18

    > Hm, I fail to get the tests functional again, I always run into some timing issue. I definitely need support on this one. Yea, because import/require are async, the test needs to be async as well, and needs to wait until the the async import has been performed. Will fix in patchset 3.
  8. Benjamin Franzke uploaded patch set 3 12/28/20, 18:19

  9. TYPO3com voted on patch set 3 V +1 12/28/20, 18:28 Completed build in 09m 36s on Mon, 28 Dec, 06:28 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8479

  10. Martin Kutschker voted on patch set 3 V +1 CR +1 12/29/20, 10:02

  11. Andreas Kienast updated the commit message in patch set 4 12/29/20, 10:14

  12. TYPO3com voted on patch set 4 V -1 12/29/20, 10:25 Completed build in 11m 09s on Tue, 29 Dec, 10:25 AM Test Summary: 31819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8489

  13. TYPO3com voted on patch set 4 V +1 12/29/20, 10:35 Completed build in 32m 24s on Tue, 29 Dec, 10:35 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8489

  14. Richard Haeser voted on patch set 4 V +1 CR +1 12/29/20, 13:23

  15. Martin Kutschker voted on patch set 4 V +1 CR +1 12/29/20, 15:28

  16. Benjamin Franzke voted on patch set 4 V +2 CR +2 12/29/20, 16:21

  17. Benjamin Franzke merged patch set 5 12/29/20, 16:22