65795[BUGFIX] Load dependencies of ImmediateActionElement dynamically
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Martin Kutschker +1
- Richard Haeser +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Martin Kutschker +1
- Richard Haeser +1
- TYPO3com +1 CI
Issues 1
Files 6
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Element/ImmediateActionElement.ts+5 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/WindowManager.ts+5 −3
- Build/Sources/TypeScript/backend/Tests/Element/ImmediateActionElementTest.ts+8 −4
- typo3/sysext/backend/Resources/Public/JavaScript/Element/ImmediateActionElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/WindowManager.js+1 −1
- typo3/sysext/backend/Tests/JavaScript/Element/ImmediateActionElementTest.js+1 −1
Review log 1217
-
Andreas Kienast uploaded patch set 1 09/20/20, 11:45
-
Andreas Kienast commented on patch set 1 09/20/20, 11:47
For v10 this needs some testing in old Edge. -
TYPO3com voted on patch set 1 V -1 09/20/20, 11:58 Completed build in 13m 04s on Sun, 20 Sep, 11:58 AM Test Summary: 4 of 74047 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5759
-
Andreas Kienast commented on patch set 1 09/20/20, 14:14
Hm, I fail to get the tests functional again, I always run into some timing issue. I definitely need support on this one. -
Benjamin Franzke uploaded patch set 2 12/28/20, 17:35
Rebase on master -
TYPO3com voted on patch set 2 V -1 12/28/20, 17:47 Completed build in 11m 13s on Mon, 28 Dec, 05:47 PM Test Summary: 5 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8476
-
Benjamin Franzke commented on patch set 2 12/28/20, 18:18
> Hm, I fail to get the tests functional again, I always run into some timing issue. I definitely need support on this one. Yea, because import/require are async, the test needs to be async as well, and needs to wait until the the async import has been performed. Will fix in patchset 3. -
Benjamin Franzke uploaded patch set 3 12/28/20, 18:19
-
TYPO3com voted on patch set 3 V +1 12/28/20, 18:28 Completed build in 09m 36s on Mon, 28 Dec, 06:28 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8479
-
Martin Kutschker voted on patch set 3 V +1 CR +1 12/29/20, 10:02
-
Andreas Kienast updated the commit message in patch set 4 12/29/20, 10:14
-
TYPO3com voted on patch set 4 V -1 12/29/20, 10:25 Completed build in 11m 09s on Tue, 29 Dec, 10:25 AM Test Summary: 31819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8489
-
TYPO3com voted on patch set 4 V +1 12/29/20, 10:35 Completed build in 32m 24s on Tue, 29 Dec, 10:35 AM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8489
-
Richard Haeser voted on patch set 4 V +1 CR +1 12/29/20, 13:23
-
Martin Kutschker voted on patch set 4 V +1 CR +1 12/29/20, 15:28
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 12/29/20, 16:21
-
Benjamin Franzke merged patch set 5 12/29/20, 16:22